Issue 4390 in pharo: OCompletion does not respect #enabled setting; it has no "off switch"

Status: Accepted
Owner: [hidden email]

New issue 4390 by [hidden email]: OCompletion does not respect  
#enabled setting; it has no "off switch"
http://code.google.com/p/pharo/issues/detail?id=4390

Pharo image: 1.3 one-click from Hudson (Pharo1.3a Latest update: #13260)

Pharo core version: <copy from World/System/About>
Virtual machine used: <ex: pharo-vm-0.15.2f-linux>
Class browser used if applicable:  OBSystemBrowserAdaptor

Steps to reproduce:
1. Settings browser, disable OCompletion
2. Note that code completion is still active

See attached fix, which modifies ECToolSet  
class>>codeCompletionAround:textMorph:keyStroke: to disallow completion  
when ECPreferences enabled answers false.  OCompletion works when enabled,  
and is silent when disabled.

Attachments:
        ECToolSet class-codeCompletionAroundtextMorphkeyStroke.st  804 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed
        Labels: Milestone-1.3-DevImage Type-Bug

Comment #1 on issue 4390 by [hidden email]: OCompletion does not  
respect #enabled setting; it has no "off switch"
http://code.google.com/p/pharo/issues/detail?id=4390

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4390 by [hidden email]: OCompletion does not  
respect #enabled setting; it has no "off switch"
http://code.google.com/p/pharo/issues/detail?id=4390

Next step:

-> Somone needs to submit a new version of the package to whatever  
repository this is coming from
-> Then somone needs to update the Metacello configs to do the right thing.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4390 by marianopeck: OCompletion does not respect  
#enabled setting; it has no "off switch"
http://code.google.com/p/pharo/issues/detail?id=4390

Done. Bill, can test  
https://pharo-ic.lille.inria.fr/hudson/view/Pharo/job/Pharo%201.3/232/  and  
tell us if it is ok ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4390 by [hidden email]: OCompletion does not  
respect #enabled setting; it has no "off switch"
http://code.google.com/p/pharo/issues/detail?id=4390

Looks good.  Thanks for integrating it!



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #5 on issue 4390 by [hidden email]: OCompletion does not  
respect #enabled setting; it has no "off switch"
http://code.google.com/p/pharo/issues/detail?id=4390

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker