Issue 4404 in pharo: [bug+fix] Refactoring a method trait should not impact classes that simply uses the trait without overwriting

Status: New
Owner: ----

New issue 4404 by [hidden email]: [bug+fix] Refactoring a method trait  
should not impact classes that simply uses the trait without overwriting
http://code.google.com/p/pharo/issues/detail?id=4404

Pharo image: 1.3 dev
Pharo core version: 13233
Virtual machine used: -
Class browser used if applicable:  OBSystemBrowserAdaptor

Steps to reproduce:
1. Create a trait T with a method m1
2. Create a class C that uses the trait T
3. rename the method m1 to m2 using the refactoring menu

You'll get a duplicate m2 method in the class C.

Fix attached


Attachments:
        RBAbstractClass-directlyDefinesMethod.st  426 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4404 by renggli: [bug+fix] Refactoring a method trait  
should not impact classes that simply uses the trait without overwriting
http://code.google.com/p/pharo/issues/detail?id=4404

Not sure, but this just seems to opens a can of worms: In the refactoring  
engine there are dozens of callers to #includeSelector: and many other  
similar selectors. The current implementation gives the engine a flattened  
view of the system without traits. Changing that will require a major  
rewrite of most parts of the code.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Invalid

Comment #2 on issue 4404 by [hidden email]: [bug+fix] Refactoring a  
method trait should not impact classes that simply uses the trait without  
overwriting
http://code.google.com/p/pharo/issues/detail?id=4404

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker