Issue 4407 in pharo: Do not care about ImageSegments on image save / image load

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4407 in pharo: Do not care about ImageSegments on image save / image load

pharo
Status: FixProposed
Owner: [hidden email]
Labels: Milestone-1.4 Type-Cleanup

New issue 4407 by [hidden email]: Do not care about ImageSegments on  
image save / image load
http://code.google.com/p/pharo/issues/detail?id=4407

There is code now to deal with imagesegments on image save / start.


   -> on save, image segments are written to files in a directory
   -> on load, image segment files that have no corresponding segment in the  
image are cleaned.

The code to load the segments on startup already was removed in the past.

As this mechanism is not used these days (and we will have something *much*  
better soon...),
I propose to remove all the code (4 methods) and simplify startup/save a  
little.

CS attached.

Attachments:
        RemoveImageSegmentSaveOnImageSave.1.cs  2.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4407 in pharo: Do not care about ImageSegments on image save / image load

pharo

Comment #1 on issue 4407 by marianopeck: Do not care about ImageSegments on  
image save / image load
http://code.google.com/p/pharo/issues/detail?id=4407

+1  because:

1) If I remember correctly, that part was broken and I fixed it some time  
ago. But nobody ever reported that, I found it.
2) Few people is using ImageSegment in general. In fact, I don't know  
anyone apart from Netstyle.net and Squeak Projects (which are not anymore  
in Pharo).
3) Not every users of ImageSegment use the default location of the files. I  
am almost sure Netstyle.net don't do that.

So, if we join 1), 2) and 3), the conclusion is that I don't know anyone  
who is using this feature. But maybe there are....

I would remove them and, in the future, if needed, do a kind of  
notification for image renaming where listeners can be registered.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4407 in pharo: Do not care about ImageSegments on image save / image load

pharo
Updates:
        Labels: -Milestone-1.4 Milestone-1.3

Comment #2 on issue 4407 by [hidden email]: Do not care about  
ImageSegments on image save / image load
http://code.google.com/p/pharo/issues/detail?id=4407

Ok, so we can even do that in 1.3


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4407 in pharo: Do not care about ImageSegments on image save / image load

pharo
Updates:
        Status: Closed

Comment #3 on issue 4407 by [hidden email]: Do not care about  
ImageSegments on image save / image load
http://code.google.com/p/pharo/issues/detail?id=4407

in 13265


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker