Issue 4409 in pharo: Form accessors analysis
Locked
 
|
Status: Accepted
Owner: [hidden email] Labels: Type-Squeak Milestone-1.4 New issue 4409 by [hidden email]: Form accessors analysis http://code.google.com/p/pharo/issues/detail?id=4409 may be there is something... we should check. ==================== Summary ==================== Name: Graphics-cmm.185 Author: cmm Time: 15 June 2011, 3:05:40.788 pm UUID: 922b52de-f4f8-3b44-809d-2c37331ccff5 Ancestors: Graphics-cmm.184 Removed position accessors from Form, since they were only used for progress-bar positioning but now we're handing back the boundingBox directly to perform on. =============== Diff against Graphics-cmm.184 =============== Item was removed: - ----- Method: Form>>bottomCenter (in category 'display box access') ----- - bottomCenter - ^ self boundingBox bottomCenter! Item was removed: - ----- Method: Form>>bottomLeft (in category 'display box access') ----- - bottomLeft - ^ self boundingBox bottomLeft! Item was removed: - ----- Method: Form>>bottomRight (in category 'display box access') ----- - bottomRight - ^ self boundingBox bottomRight! Item was changed: ----- Method: Form>>center (in category 'display box access') ----- center + "Note that offset is ignored here. Are we really going to embrace offset? " + ^ (width @ height) // 2! - ^ self boundingBox center! Item was removed: - ----- Method: Form>>leftCenter (in category 'display box access') ----- - leftCenter - ^ self boundingBox leftCenter! Item was removed: - ----- Method: Form>>rightCenter (in category 'display box access') ----- - rightCenter - ^ self boundingBox rightCenter! Item was removed: - ----- Method: Form>>topCenter (in category 'display box access') ----- - topCenter - ^ self boundingBox topCenter! Item was removed: - ----- Method: Form>>topLeft (in category 'display box access') ----- - topLeft - ^ self boundingBox topLeft! Item was removed: - ----- Method: Form>>topRight (in category 'display box access') ----- - topRight - ^ self boundingBox topRight! _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
|
|
Comment #1 on issue 4409 by [hidden email]: Form accessors analysis http://code.google.com/p/pharo/issues/detail?id=4409 ==================== Summary ==================== Name: Graphics-cmm.184 Author: cmm Time: 15 June 2011, 11:16:09.001 am UUID: 32d27338-5068-764e-b00a-244caed09044 Ancestors: Graphics-cmm.183 - Added remaining Rectangle-access methods to Form. - Updated senders of #displayProgressAt:from:... to #displayProgressFrom:... to allow honoring of the preference. =============== Diff against Graphics-cmm.183 =============== Item was added: + ----- Method: Form>>bottomLeft (in category 'display box access') ----- + bottomLeft + ^ self boundingBox bottomLeft! Item was added: + ----- Method: Form>>bottomRight (in category 'display box access') ----- + bottomRight + ^ self boundingBox bottomRight! Item was added: + ----- Method: Form>>topLeft (in category 'display box access') ----- + topLeft + ^ self boundingBox topLeft! Item was added: + ----- Method: Form>>topRight (in category 'display box access') ----- + topRight + ^ self boundingBox topRight! Item was changed: ----- Method: HostFont class>>textStyleFrom: (in category 'accessing') ----- textStyleFrom: fontName "HostFont textStyleFromUser" | styleName fonts | styleName := fontName asSymbol. "(TextConstants includesKey: styleName) ifTrue:[(self confirm: styleName , ' is already defined in TextConstants. Do you want to replace that definition?') ifFalse: [^ self]]." fonts := #(10 11 12 13 14 16 18 20 22 24 26 28 30 36 48 60 72 90). + ('Rendering ', styleName) displayProgressFrom: 1 to: fonts size during:[:bar| - ('Rendering ', styleName) displayProgressAt: Sensor cursorPoint - from: 1 to: fonts size during:[:bar| fonts := fonts collect:[:ptSize| bar value: (fonts indexOf: ptSize). self fontName: styleName size: ptSize emphasis: 0] thenSelect:[:font| font notNil]]. "reject those that failed" fonts size = 0 ifTrue:[^self error:'Could not create font style', styleName]. TextConstants at: styleName put: (TextStyle fontArray: fonts).! Item was changed: ----- Method: HostFont class>>textStyleFrom:sizes: (in category 'accessing') ----- textStyleFrom: fontName sizes: ptSizes | styleName fonts | styleName := fontName asSymbol. (TextConstants includesKey: styleName) ifTrue:[(self confirm: styleName , ' is already defined in TextConstants. Do you want to replace that definition?') ifFalse: [^ self]]. + ('Rendering ', styleName) displayProgressFrom: 1 to: ptSizes size during:[:bar| - ('Rendering ', styleName) displayProgressAt: Sensor cursorPoint - from: 1 to: ptSizes size during:[:bar| fonts := ptSizes collect:[:ptSize| bar value: (ptSizes indexOf: ptSize). self fontName: styleName size: ptSize emphasis: 0] thenSelect:[:font| font notNil]]. "reject those that failed" fonts size = 0 ifTrue:[^self error:'Could not create font style', styleName]. TextConstants at: styleName put: (TextStyle fontArray: fonts).! Item was changed: ----- Method: HostFont class>>textStyleFrom:sizes:ranges: (in category 'accessing') ----- textStyleFrom: fontName sizes: ptSizes ranges: ranges | styleName fonts | styleName := fontName asSymbol. (TextConstants includesKey: styleName) ifTrue:[(self confirm: styleName , ' is already defined in TextConstants. Do you want to replace that definition?') ifFalse: [^ self]]. + ('Rendering ', styleName) displayProgressFrom: 1 to: ptSizes size during:[:bar| - ('Rendering ', styleName) displayProgressAt: Sensor cursorPoint - from: 1 to: ptSizes size during:[:bar| fonts := ptSizes collect:[:ptSize| bar value: (ptSizes indexOf: ptSize). self fontName: styleName size: ptSize emphasis: 0 rangesArray: ranges ] thenSelect:[:font| font notNil]]. "reject those that failed" fonts size = 0 ifTrue:[^self error:'Could not create font style', styleName]. TextConstants at: styleName put: (TextStyle fontArray: fonts).! Item was changed: ----- Method: HostFont class>>textStyleFromUser (in category 'accessing') ----- textStyleFromUser "HostFont textStyleFromUser" | styleName fonts | styleName := self fontNameFromUser ifNil:[^self]. styleName := styleName asSymbol. (TextConstants includesKey: styleName) ifTrue:[(self confirm: styleName , ' is already defined in TextConstants. Do you want to replace that definition?') ifFalse: [^ self]]. fonts := #(10 12 14 16 18 20 22 24 26 28 30 36 48 60 72 90). + ('Rendering ', styleName) displayProgressFrom: 1 to: fonts size during:[:bar| - ('Rendering ', styleName) displayProgressAt: Sensor cursorPoint - from: 1 to: fonts size during:[:bar| fonts := fonts collect:[:ptSize| bar value: (fonts indexOf: ptSize). self fontName: styleName size: ptSize emphasis: 0] thenSelect:[:font| font notNil]]. "reject those that failed" fonts size = 0 ifTrue:[^self error:'Could not create font style', styleName]. TextConstants at: styleName put: (TextStyle fontArray: fonts).! _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
|
|
Comment #2 on issue 4409 by [hidden email]: Form accessors analysis http://code.google.com/p/pharo/issues/detail?id=4409 Chris Muller uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-cmm.183.mcz ==================== Summary ==================== Name: Graphics-cmm.183 Author: cmm Time: 27 May 2011, 2:35:44.268 pm UUID: 08000000-1508-b80b-1508-b80b14000000 Ancestors: Graphics-nice.182 Added remaining Rectangle position accessors (besides just #center) to Form, for placement convenience. =============== Diff against Graphics-nice.182 =============== Item was added: + ----- Method: Form>>bottomCenter (in category 'display box access') ----- + bottomCenter + ^ self boundingBox bottomCenter! Item was changed: + ----- Method: Form>>center (in category 'display box access') ----- - ----- Method: Form>>center (in category 'accessing') ----- center + ^ self boundingBox center! - "Note that offset is ignored here. Are we really going to embrace offset? " - ^ (width @ height) // 2! Item was changed: + ----- Method: Form>>height (in category 'display box access') ----- - ----- Method: Form>>height (in category 'accessing') ----- height ^ height! Item was added: + ----- Method: Form>>leftCenter (in category 'display box access') ----- + leftCenter + ^ self boundingBox leftCenter! Item was added: + ----- Method: Form>>rightCenter (in category 'display box access') ----- + rightCenter + ^ self boundingBox rightCenter! Item was added: + ----- Method: Form>>topCenter (in category 'display box access') ----- + topCenter + ^ self boundingBox topCenter! Item was changed: + ----- Method: Form>>width (in category 'display box access') ----- - ----- Method: Form>>width (in category 'accessing') ----- width ^ width! _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
|
|
Updates:
Labels: -Milestone-1.4 Comment #3 on issue 4409 by [hidden email]: Form accessors analysis http://code.google.com/p/pharo/issues/detail?id=4409 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
|
|
Updates:
Status: WorkNeeded Comment #4 on issue 4409 by [hidden email]: Form accessors analysis http://code.google.com/p/pharo/issues/detail?id=4409 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
|
|
Updates:
Status: Invalid Comment #5 on issue 4409 by [hidden email]: Form accessors analysis http://code.google.com/p/pharo/issues/detail?id=4409 Nobody cared for this for over 1 year. Closed _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
«
Return to Pharo Issue Tracker
|
1 view|%1 views
| Free forum by Nabble | Edit this page |