Issue 4417 in pharo: Zinc does not honour network proxy configuration....

Status: New
Owner: ----

New issue 4417 by [hidden email]: Zinc does not honour network  
proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

The action:

ZnClient get: 'http://caretaker.wolf359.be/small.html'. ->

results in

a ZnResponse(407 Proxy Authentication Required ( The ISA Server requires  
authorization to fulfill the request. Access to the Web Proxy filter is  
denied.  ) text/html 4552B)

The client does not use the proxy-credentials.



Image: Pharo1.3a Update 13262
System: WinXP 32Bit


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #1 on issue 4417 by marianopeck: Zinc does not honour network proxy  
configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4417 by [hidden email]: Zinc does not honour  
network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

Thanks for reporting this, you seem to be the first who runs into this.

HTTPSocket does indeed have a class variable called HTTPProxyCredentials,  
but apart from some methods that set it, this setting does not seem to be  
used anywhere. BTW, setting a proxy username and/or password does not seem  
to be supported by the Pharo Settings UI.

It would not be too difficult to add an Proxy-Authorization header when  
needed, I think.

I will look into this (aka, put it on my list).

Sven



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #3 on issue 4417 by marianopeck: Zinc does not honour network proxy  
configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4417 by [hidden email]: Zinc does not honour  
network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

see the screenshot, we already have settings for proxy and authentication.
How to set/get current username and password and port and server name ?
I will update the settings.
Alain

Attachments:
        PharoScreenshot.1.png  25.4 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4417 by [hidden email]: Zinc does not honour  
network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

OK, I somehow looked over it ;-)

If you enter data in the fields, it shows up in class variable  
HTTPProxyCredentials of HTTPSocket so that seems to work.

Sven


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4417 by [hidden email]: Zinc does not  
honour network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

Yes - I entered my user/password combination into the preferences  
interface. Pharo 1.2 is using these values - you have observed this.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4417 by [hidden email]: Zinc does not  
honour network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

  I could not update my pharo image from behind my corporate firewall.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4417 by [hidden email]: Zinc does not honour  
network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

I have a version, but I still need to test it (I have to set up a proxy).

Since SqueakSource is down I cannot commit.

Sven


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 4417 by [hidden email]: Zinc does not  
honour network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

Could you attach the fix here - because I can not access squeacksource  
through pharo ;)



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4417 by [hidden email]: Zinc does not honour  
network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

I'll do some testing this afternoon.

==================== Summary ====================

Name: Zinc-HTTP-SvenVanCaekenberghe.164
Author: SvenVanCaekenberghe
Time: 17 June 2011, 9:16:22 am
UUID: 90d57d3d-fc41-4548-a2fd-dcd7c22a3a1f
Ancestors: Zinc-HTTP-SvenVanCaekenberghe.163

implemented support for proxies that require authorization;
ZnHeaders class>>#requestHeadersFor: will add a Proxy-Authorization header  
when needed;
added public API ZnNetworkingUtils  
class>>#proxyAuthorizationHeaderValueToUrl:
removed public API ZnNetworkingUtils class>>#httpProxy and #isProxySet;
upgraded public API ZnNetworkingUtils class>>#shouldProxyUrl: to be a  
primary interface;
refactored internals of ZnNetworkUtils to use NetworkSystemSettings  
directly instead of HTTPSocket;

this code still has to be tested and validated with real world proxies


Attachments:
        Zinc-HTTP-SvenVanCaekenberghe.164.mcz  125 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed
        Labels: Milestone-1.3 Milestone-1.4

Comment #11 on issue 4417 by [hidden email]: Zinc does not honour  
network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 4417 by [hidden email]: Zinc does not  
honour network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

One little change is needed and it works for me:

httpProxyUser
        "Return the user for proxy authorization"
+ ^ NetworkSystemSettings proxyUser
- ^ NetworkSystemSettings proxyPassword


Attachments:
        Zinc-HTTP-MarcoSchmidt.165.mcz  124 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 4417 by [hidden email]: Zinc does not  
honour network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

I added the file to the SS-Repo too...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 4417 by [hidden email]: Zinc does not honour  
network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

Hi Marco,

Good, I merged it with my latest checkin.

Thanks!

Sven


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #15 on issue 4417 by [hidden email]: Zinc does not  
honour network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

After updating the configuration it should be ok to close the issue.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #16 on issue 4417 by [hidden email]: Zinc does not honour  
network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

I have to admit I am confused what what to load.

Can someone put the version(s) in the inbox?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #17 on issue 4417 by [hidden email]: Zinc does not honour  
network proxy configuration....
http://code.google.com/p/pharo/issues/detail?id=4417

in 13271 and 14005


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker