Issue 4513 in pharo: ScrollBar and MorphicModel needs cleaning

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4513 in pharo: ScrollBar and MorphicModel needs cleaning

pharo
Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.4

New issue 4513 by [hidden email]: ScrollBar and MorphicModel needs  
cleaning
http://code.google.com/p/pharo/issues/detail?id=4513

Just found that scrollbars are assigned 'slotname' when you creating them
and when it comes to send events to their model, it end up in this method:

use: cachedSelector orMakeModelSelectorFor: selectorBody in: selectorBlock
        | selector |
        model ifNil: [^ nil].
        cachedSelector ifNil:
                        ["Make up selector from slotname if any"
                        selector := (slotName ifNil: [selectorBody]
                                                                ifNotNil:  
[slotName , selectorBody]) asSymbol.
                        (model class canUnderstand: selector) ifFalse:
                                [(self confirm: 'Shall I compile a null  
response for'
                                                        , Character cr  
asString
                                                        , model class  
name , '>>' , selector)
                                                ifFalse: [self halt].
                                model class compile: (String streamContents:
                                                                [:s |  
selector keywords doWithIndex:
                                                                                 
[:k :i  
| s nextPutAll: k , ' arg' , i printString].
                                                                s cr;  
nextPutAll: '"Automatically generated null response."'.
                                                                s cr;  
nextPutAll: '"Add code below for appropriate behavior..."'.])
                                                        classified: 'input  
events'
                                                        notifying: nil]]
                ifNotNil:
                        [selector := cachedSelector].
        ^ selectorBlock value: selector


this is incredible..


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4513 in pharo: ScrollBar and MorphicModel needs cleaning

pharo
Updates:
        Status: FixProposed

Comment #1 on issue 4513 by [hidden email]: ScrollBar and  
MorphicModel needs cleaning
http://code.google.com/p/pharo/issues/detail?id=4513

Part one in 14056


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4513 in pharo: ScrollBar and MorphicModel needs cleaning

pharo

Comment #2 on issue 4513 by [hidden email]: ScrollBar and  
MorphicModel needs cleaning
http://code.google.com/p/pharo/issues/detail?id=4513

(No comment was entered for this change.)

Attachments:
        scrollbar2.1.cs  1.5 KB
        slotScroll.1.cs  3.8 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4513 in pharo: ScrollBar and MorphicModel needs cleaning

pharo

Comment #3 on issue 4513 by [hidden email]: ScrollBar and  
MorphicModel needs cleaning
http://code.google.com/p/pharo/issues/detail?id=4513

part two 14057


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4513 in pharo: ScrollBar and MorphicModel needs cleaning

pharo
Updates:
        Cc: [hidden email]

Comment #4 on issue 4513 by [hidden email]: ScrollBar and  
MorphicModel needs cleaning
http://code.google.com/p/pharo/issues/detail?id=4513

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4513 in pharo: ScrollBar and MorphicModel needs cleaning

pharo

Comment #5 on issue 4513 by [hidden email]: ScrollBar and  
MorphicModel needs cleaning
http://code.google.com/p/pharo/issues/detail?id=4513

Gary may be we should now clean the accessor and setValueSelector.
Tell us what you think


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4513 in pharo: ScrollBar and MorphicModel needs cleaning

pharo
Updates:
        Status: Closed

Comment #6 on issue 4513 by [hidden email]: ScrollBar and  
MorphicModel needs cleaning
http://code.google.com/p/pharo/issues/detail?id=4513

I closed this issue for now.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker