Issue 4521 in pharo: ChangeSet changedMessageList broken and accessors missing

Status: New
Owner: ----

New issue 4521 by [hidden email]: ChangeSet changedMessageList  
broken and accessors missing
http://code.google.com/p/pharo/issues/detail?id=4521

As discussed in  
http://forum.world.st/ChangeSet-changedMessageList-broken-td3541237.html


Pharo image: Pharo
Pharo core version: Pharo1.3 Latest update: #13281

Unfortunately the monticello tools do not seem to pick up all the changes  
for some reason, thus, here the following steps to fix it:

1. Moving MethodReference>>#topLevelPackageName to its superclass
   (SourceReference)

2. Add CommentReference>>#category
    category
    ^ self actualClass category

3. Add ChangeSet>>#changeRecords
    changeRecords
    ^ changeRecords

4. Change ChangeSet>>#changedMessageList
    to use CommentReference instead of SourcedMethodReference for the class
     comment

    (CommentReference class: (Smalltalk globals classNamed: classNameInParts  
first))




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed
        Labels: Milestone-1.4

Comment #1 on issue 4521 by [hidden email]: ChangeSet  
changedMessageList broken and accessors missing
http://code.google.com/p/pharo/issues/detail?id=4521

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ReviewNeeded

Comment #2 on issue 4521 by [hidden email]: ChangeSet  
changedMessageList broken and accessors missing
http://code.google.com/p/pharo/issues/detail?id=4521

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Bug

Comment #3 on issue 4521 by [hidden email]: ChangeSet  
changedMessageList broken and accessors missing
http://code.google.com/p/pharo/issues/detail?id=4521

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #4 on issue 4521 by [hidden email]: ChangeSet  
changedMessageList broken and accessors missing
http://code.google.com/p/pharo/issues/detail?id=4521

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: NoSourcesAvailable

Comment #5 on issue 4521 by [hidden email]: ChangeSet  
changedMessageList broken and accessors missing
http://code.google.com/p/pharo/issues/detail?id=4521

Next action: Code needs to be attached in machine readable form


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4521 by [hidden email]: ChangeSet changedMessageList  
broken and accessors missing
http://code.google.com/p/pharo/issues/detail?id=4521

This issue can be closed for 1.4, it is broken beyond repair, and fixing it  
does not fit your vision.

The only real question is, why are you still keeping MethodReference and  
related classes around, shouldn't they be completely replaced by Ring?!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Invalid

Comment #7 on issue 4521 by [hidden email]: ChangeSet  
changedMessageList broken and accessors missing
http://code.google.com/p/pharo/issues/detail?id=4521

yes, it will be removed... the whole MethodReference hierarchy is not used  
in 1.4 anymore.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker