Status: Accepted
Owner:
[hidden email]
Labels: Milestone-1.4
New issue 4537 by
[hidden email]: Removing Canvas>>shadowColor &
friends cleanup
http://code.google.com/p/pharo/issues/detail?id=4537This changesets removing shadowColor notion from Canvas
and leaving it only in ShadowDrawingCanvas.
in #drawDropShadowOn:
it is better to render the shadow by ourselves by using appropriate
shadowColor,
instead of setting up shadow canvas and then passing it to #drawOn:
It is simplifying canvas api, because its no longer needs to support the
notion of shadowColor, and hence i removed a lot of checks everywhere like:
self shadowColor ifNotNil: [... ].
The rationale of this change is , that canvas (unless it is special kind ,
like ShadowDrawingCanvas), should not have any notion of shadow, because
this is completely irrelevant to it. Canvas should take a simple drawing
commands and don't contain any extra logic. If application (or UI) has a
notion of 'shadow' then it should be up to application how to display it,
but not canvas.
Attachments:
shadow-removal.1.cs 24.4 KB
shadow-removal2.1.cs 502 bytes
_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Locked
