Issue 4547 in pharo: Implementors of... always brings the same implementors window

Status: Accepted
Owner: [hidden email]

New issue 4547 by [hidden email]: Implementors of... always brings  
the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

In Pharo 1.4 Latest update: #14050

Browse implementors of any message.
 From this window, activate the pop up menu in message list and ask  
for 'implementors of ... (m)'

I expect this menu item to propose a list of messages sent by the selected  
method. Instead of that, it opens a window with implementors of selected  
message. This is plain stupid, it's already from such a window that I made  
the request !

In the browser, the menu works as expected.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

Senders of ... (n) behaves the same:
- from a list of implementors, it will browse senders of selected message.
- from the Browser, it will propose a menu of all messages sent by the  
selected message.

1) It would be good to keep homogeneity
2) Personally I prefer the browser behaviour
3) How to browse the implementors/senders of one of the messages sent  
(especially if it is composed of several keywords)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]
        Labels: Milestone-1.4

Comment #2 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

1) Since we are rewriting the tools, we are also defining the homogeneity,  
but for sure, we have to be consistent
2) I like it too in certain cases.
3) Normally (when it works) if you highlight a message (even made with  
several words) and you press cmd+n it browse the senders. But it doesn't  
work very well for now.

By the way, we should just decide what we want, and implement the chosen  
behavior everywhere.

To be honest, my todo list is quite huge and I am on holidays, so I will  
try to have a look, but I do not promise anything


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: -[hidden email] [hidden email]

Comment #4 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

Issue 4612 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Bug

Comment #6 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

IDE is important for me so I'll open a discussion in the mailing list ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

Ben could you make sure that we get a list of messages instead of the same  
browser.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #9 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

Ben can you have a look at my proposal :)

Attachments:
        Fixing implementors.1.cs  2.8 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

Slice is in the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

I am currently reviewing your cs. Some part seems strange (we can improve  
StringHolder behavior ^^)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #12 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #13 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

I just posted a new slice which includes your cs.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

Missing extension fixed


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #15 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

looks good


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #16 on issue 4547 by [hidden email]: Implementors of...  
always brings the same implementors window
http://code.google.com/p/pharo/issues/detail?id=4547

in 14414


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker