Issue 4555 in pharo: Fix SUnit to prevent forked process from escaping to debugger

Status: FixProposed
Owner: [hidden email]
Labels: Milestone-1.4 Importance-High

New issue 4555 by [hidden email]: Fix SUnit to prevent forked process  
from escaping to debugger
http://code.google.com/p/pharo/issues/detail?id=4555

This is fix for TestCase>>should:notTakeMoreThan:
to handle exception during evaluation of block in forked process.

This fix is important for running tests in headless mode, because without  
it, an image simply quits to OS because of attempt to open a debugger  
window.

Attachments:
        testcase-fix.2.cs  1.4 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #1 on issue 4555 by [hidden email]: Fix SUnit to prevent forked  
process from escaping to debugger
http://code.google.com/p/pharo/issues/detail?id=4555

in [update 1.4] #14061


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Started

Comment #2 on issue 4555 by renggli: Fix SUnit to prevent forked process  
from escaping to debugger
http://code.google.com/p/pharo/issues/detail?id=4555

Why does the fix not use BlockClosure>>#valueWithin:onTimeout:?

The fix does in fact duplicate the behavior that is already present in the  
system. Furthermore, the existing implementation executes the block in the  
owning process and makes the watchdog external, which IMHO solves the  
problem in a much nicer way.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.3

Comment #3 on issue 4555 by [hidden email]: Fix SUnit to prevent  
forked process from escaping to debugger
http://code.google.com/p/pharo/issues/detail?id=4555

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4555 by [hidden email]: Fix SUnit to prevent  
forked process from escaping to debugger
http://code.google.com/p/pharo/issues/detail?id=4555

Issue 4559 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4555 by [hidden email]: Fix SUnit to prevent forked  
process from escaping to debugger
http://code.google.com/p/pharo/issues/detail?id=4555

@Lukas:
i just modified what was there. But you right, using  
BlockClosure>>#valueWithin:onTimeout: would be much nicer.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4555 by [hidden email]: Fix SUnit to prevent forked  
process from escaping to debugger
http://code.google.com/p/pharo/issues/detail?id=4555

here another fix.
implementations is much more cleaner! :)

Attachments:
        fix-4555-oncemore.2.cs  492 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #7 on issue 4555 by [hidden email]: Fix SUnit to prevent  
forked process from escaping to debugger
http://code.google.com/p/pharo/issues/detail?id=4555

in 13289

TODO: 1.4


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #8 on issue 4555 by [hidden email]: Fix SUnit to prevent  
forked process from escaping to debugger
http://code.google.com/p/pharo/issues/detail?id=4555

in 14061 apparently :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 4555 by [hidden email]: Fix SUnit to prevent forked  
process from escaping to debugger
http://code.google.com/p/pharo/issues/detail?id=4555

> in 14061 apparently :)
you replaced my update with new changeset?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Started

Comment #10 on issue 4555 by [hidden email]: Fix SUnit to prevent  
forked process from escaping to debugger
http://code.google.com/p/pharo/issues/detail?id=4555

I think we need to merge the new one


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #11 on issue 4555 by [hidden email]: Fix SUnit to prevent  
forked process from escaping to debugger
http://code.google.com/p/pharo/issues/detail?id=4555

in 14062


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 4555 by [hidden email]: Fix SUnit to prevent  
forked process from escaping to debugger
http://code.google.com/p/pharo/issues/detail?id=4555

Ok thanks. Indeed a new update was necessary.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker