Issue 4567 in pharo: Ring fix

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4567 in pharo: Ring fix

pharo
Status: ReviewNeeded
Owner: [hidden email]
Labels: Milestone-1.4

New issue 4567 by [hidden email]: Ring fix
http://code.google.com/p/pharo/issues/detail?id=4567

minor improvement in ClassDescription>>definition


Attachments:
        ClassDescription-definition.st  1.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4567 in pharo: Ring fix

pharo

Comment #1 on issue 4567 by [hidden email]: Ring fix
http://code.google.com/p/pharo/issues/detail?id=4567

Hi veronica

I was reading your change in

        ClassDescription>>definition
               
                aStream cr; tab; nextPutAll: 'category: ';
                        store: self category asString.
                        replaced by
                        store: (self environment organization categoryOfElement: self name)  
asString.


and I'm wondering why this is needed? Because I was thinking that I would  
prefer to have category fixed. Now category


Class>>category
        "Answer the system organization category for the receiver. First check  
whether the
        category name stored in the ivar is still correct and only if this fails  
look it up
        (latter is much more expensive)"

        | result |
        self basicCategory ifNotNil: [ :symbol |
                ((self environment organization listAtCategoryNamed: symbol) includes:  
self name)
                        ifTrue: [ ^symbol ] ].
        self basicCategory: (result := self environment organization  
categoryOfElement: self name).
        ^result


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4567 in pharo: Ring fix

pharo

Comment #2 on issue 4567 by [hidden email]: Ring fix
http://code.google.com/p/pharo/issues/detail?id=4567

My change is basically what TraitDescription>>definition is doing.

I found that ClassDescription>>definition was taking more time in getting  
the category than TraitDescription>>definition, which is directly accessing  
#category.







_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4567 in pharo: Ring fix

pharo

Comment #3 on issue 4567 by [hidden email]: Ring fix
http://code.google.com/p/pharo/issues/detail?id=4567

Ok I will check when I'm not dead :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4567 in pharo: Ring fix

pharo
Updates:
        Labels: Type-Bug

Comment #4 on issue 4567 by [hidden email]: Ring fix
http://code.google.com/p/pharo/issues/detail?id=4567

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4567 in pharo: Ring fix

pharo
Updates:
        Status: FixReviewNeeded

Comment #5 on issue 4567 by [hidden email]: Ring fix
http://code.google.com/p/pharo/issues/detail?id=4567

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4567 in pharo: Ring fix

pharo
Updates:
        Status: FixToInclude

Comment #6 on issue 4567 by [hidden email]: Ring fix
http://code.google.com/p/pharo/issues/detail?id=4567

yes, looks good


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4567 in pharo: Ring fix

pharo
Updates:
        Status: Integrated

Comment #7 on issue 4567 by [hidden email]: Ring fix
http://code.google.com/p/pharo/issues/detail?id=4567

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker