Issue 4571 in pharo: Use becomeForward, not become

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.4

New issue 4571 by [hidden email]: Use becomeForward, not become
http://code.google.com/p/pharo/issues/detail?id=4571

just checked senders of #become:
and found multiple places where it would be better to use #becomeForward:

CompiledMethod>>putSource:fromParseNode:inFile:withPreamble:
MethodDictionary>>compact , grow, rehash , removeAll, removeKey:ifAbsent:

SmalltalkImage>>recreateSpecialObjectsArray


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #1 on issue 4571 by marianopeck: Use becomeForward, not become
http://code.google.com/p/pharo/issues/detail?id=4571

MethodDictionary was refactored due to issue 4826 of the #rehash. Only one  
was pending, which I have replaced with #becomeFordward.

I have also changed  
CompiledMethod>>putSource:fromParseNode:inFile:withPreamble:
and #recreateSpecialObjectsArray

I have updated much more as well.

I tried to be careful and put #becomeForward: instead of #become when it  
was worth it. Because there can a case where such #becomeForward: is sent a  
lot of times and if even if we could use #becomeForward:, if the objects  
are the same size, then we may want to use #become to take advantage of the  
optimization Igor did with #become when both obejcts have the same size.  
So...a pending review is to check all senders of #becomeForward and see if  
both objects may have the same size and if speed is a concern. If true,  
replace with #become:

Since slices do not work anymore in 1.4 I attach a changeset.



Attachments:
        UseBecomeForwardInsteadOfBecome.1.cs  97 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Started

Comment #2 on issue 4571 by [hidden email]: Use becomeForward, not  
become
http://code.google.com/p/pharo/issues/detail?id=4571

the change set is empty


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4571 by marianopeck: Use becomeForward, not become
http://code.google.com/p/pharo/issues/detail?id=4571

grrrrrr

ok, here it is again.

Attachments:
        MethodDictionaryRehashSpeedUpV3.1.cs  4.9 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #4 on issue 4571 by [hidden email]: Use becomeForward, not  
become
http://code.google.com/p/pharo/issues/detail?id=4571

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Started

Comment #5 on issue 4571 by [hidden email]: Use becomeForward, not  
become
http://code.google.com/p/pharo/issues/detail?id=4571

Hmm... to me it looks like all these changes are in 1.4 already


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4571 by marianopeck: Use becomeForward, not become
http://code.google.com/p/pharo/issues/detail?id=4571

uffffff I mess up everything. I send the attach of the MethodDictionary  
rehash and not the one of the becomeForward...grrr I will need to search  
it. Sorry for the mess


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #7 on issue 4571 by marianopeck: Use becomeForward, not become
http://code.google.com/p/pharo/issues/detail?id=4571

Here it is. Sorry for the noise.

Attachments:
        ReplaceBecomeWitgBecomeForwardV4.1.cs  8.0 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Feature

Comment #8 on issue 4571 by [hidden email]: Use becomeForward, not  
become
http://code.google.com/p/pharo/issues/detail?id=4571

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #9 on issue 4571 by [hidden email]: Use becomeForward, not  
become
http://code.google.com/p/pharo/issues/detail?id=4571

in 14174


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Started

Comment #10 on issue 4571 by [hidden email]: Use becomeForward, not  
become
http://code.google.com/p/pharo/issues/detail?id=4571

No, I think this needs to be updated again?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 4571 by marianopeck: Use becomeForward, not become
http://code.google.com/p/pharo/issues/detail?id=4571

why?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 4571 by [hidden email]: Use becomeForward, not  
become
http://code.google.com/p/pharo/issues/detail?id=4571

It is changing MethodDictionary>>#grow which was changed in the meantime?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #13 on issue 4571 by [hidden email]: Use becomeForward, not  
become
http://code.google.com/p/pharo/issues/detail?id=4571

in 14174


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker