Issue 4572 in pharo: Last reference to MessageSet

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Milestone-1.4 Difficulty-Easy

New issue 4572 by [hidden email]: Last reference to MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

MessageSet should be replaced by MessageList.
MessageSet subclass is not referenced anymore.
in 1.4 there are only two references left that refer to MessageSet

ToolRegistry>>messageSet
^MessageSet .


and

        setClassAndSelectorIn: csBlock
                [ | strm class sel |
                strm :=  self selection asString readStream.
                strm skipTo: $}.
                strm atEnd ifTrue:  [ ^ contents := nil ].
                strm skipSeparators.
                class := strm upToAll: '>>'.
                (class includes: $() ifTrue: [
                class := (class copyAfter: $() copyUpTo: $)].
                sel := strm upToEnd.
                ^ (Smalltalk at: #MessageSet)
                        parse: class, ' ', sel
                        toClassAndSelector: csBlock ]
                        on: Error
                        do: [ :ex | ^ contents := nil ]

It would be nice to check if MessageList replacement works and that we can  
deprecate MessageSet and subclasses.
If somebody would like to help this would be good.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

I've done the replacement and appearently everything's all right. :)All  
tests green.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

cool!
Even such simple tests help. Thanks a lot.

Can you publish the changesets?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

yes, I'll publish a slice ASAP :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

Name: SLICE-Issue-4572-Last-Reference-to-Message-Set-ClaraAllende.1
Author: ClaraAllende
Time: 1 August 2011, 5:07:50 pm
UUID: 761cf876-fcf2-3e46-84ab-283a5dd938d3
Ancestors:
Dependencies: System-Tools-ClaraAllende.57, Tools-ClaraAllende.639

Made replacements and test for MessageList


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

thanks clara.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

I can not merge the slice.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

I haven't had problems with the merge :O


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

Name: SLICE-Issue-4572-Last-Reference-to-Message-Set-ClaraAllende.2
Author: ClaraAllende
Time: 4 August 2011, 11:25:41 am
UUID: 943258ed-be74-9b41-9e11-b24ce4f6b771
Ancestors:

empty log message

I wasn't using the last build :S Now there should not be problems... At  
least no conflicts when I did the merge


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

Name: SLICE-Issue-4572-Last-Reference-to-Message-Set-ClaraAllende.1

has no Dependencies, so merging has no effect


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

clara can you republish your change and add the packages to the slice?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

right now I'm debugging code at work, but I will check this out ASAP.
Hopefully tonight I can publish a new slice. tx for your patience :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

Right now I'm a little bit busy at work, but I'll check this out ASAP.  
Hopefully tonight or maybe tomorrow morning I can publish a new slice. Tx  
for your patience :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

Thanks clara. We should improve the ui because people woud not make mistake  
if it would be good.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

hehe, people could make mistakes either way stef :) but I agree, the better  
the UI the less error rate :D So here is the new slice :)

Name: SLICE-Issue-4572-Last-Reference-to-MessageSet-ClaraAllende.2
Author: ClaraAllende
Time: 19 August 2011, 7:25:13 pm
UUID: 4c0c8d91-fe73-2c42-965b-9bc5fc6d44fe
Ancestors: SLICE-Issue-4572-Last-Reference-to-MessageSet-ClaraAllende.1
Dependencies: System-Tools-ClaraAllende.60, Tools-ClaraAllende.643

Check the timestamp, there's another one I did this morning which has  
problems with the merge, this last one doesn't


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #15 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: closed

Comment #16 on issue 4572 by [hidden email]: Last reference to  
MessageSet
http://code.google.com/p/pharo/issues/detail?id=4572

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker