Issue 4573 in pharo: Should deprecate TimeProfileBrowser

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.4 Difficulty-Easy

New issue 4573 by [hidden email]: Should deprecate TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

TimeProfilerBrowser is a subclass of MessageSet. And we will deprecate  
MessageSet. Now we have a good replacement for TimeProfileBrowser, namely  
TimeProfiler so we can deprecate TimeProfileBrowser.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

sadly,
TimeProfiler class doesn't provide the following creation method

TimeProfileBrowser class>>
  spyOnProcess: aProcess forMilliseconds: msecDuration
        "Run aProcess for msecDuration milliseconds, then open a  
TimeProfileBrowser on the results."


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

it's used in ProcessBrowser>>messageTally.
any ideas?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

We should replace it by opening TimeProfilerBrowser.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

i don't get your last comment.
could you explain it?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

TimeProfiler is just a UI so we should replace references to  
TimeProfilerBrowser by TimeProfiler and we should may be add some missing  
methods. Normally they should be available in the model of TimeProfiler.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #6 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

I added TimeProfiler to ToolRegistry(don't forget to resetTools, see  
postscript)
I changed all references to TimeProfileBrowser to Smalltalk tools  
timeProfiler
also i had to use Accuny TextStyle or otherwise several methods from
FreeTypeFont(profiling category) failed

ParagraphEditor>>tallySelection belongs to category Deprecated13, nothing  
to do.

and i managed to add TimeProfiler>>spyOnProcess:forMilliSeconds:

Someone should review this change, PLEASE!

Attachments:
        issue-4573-Should-deprecate-TimeProfileBrowser.5.cs  37.4 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

but I guess that a TT font must be used for FreeTypeFont profiling, not a  
bitmap font (accuny is a bitmap font). btw, accuny will be removed from the  
system.
I would only touch what is related to this issue. If you noticed a problem  
with FreeTypeFont, please open a specific issue


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

as you suggested, i submitted another issue 4805.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

Ok so should I integrate the slice?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

i would say no until issue 4805 is fixed.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

maybe you could remove from your slice all parts which are related to  
FreeTypeFont profiling and propose another slice with only ypur  
Timeprofiler's fixes. It would be cool to integrate them :)



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

here you have. But, remember FreeTypeFont still has references to  
TimeProfileBrowser.

Attachments:
        issue-4573-Should-deprecate-TimeProfileBrowser-2.1.cs  7.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

I would remove the profiling methods in Font because why a font should  
refere to a profiler....
It makes not that much sense.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

Thanks!
I've removed all TimeProfileBrowser reference, even in FT package since  
there is another issue for FT now :)

in InBox:

SLICE-Issue-4573-Should-deprecate-TimeProfileBrowser-AlainPlantec.1
a postscript is needed:
-----
Smalltalk resetTools.
------



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #15 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

in 14146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #16 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

Indeed, TimeProfiler using have to removed from FreeTypeFont class.
entered issue 4815 for that point.

concerning this issue, it is not fully fixed since "Start profiling all  
processes" accessible from the system menu still make use of the  
TimeProfileBrowser ...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #17 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

but alain the code is more like :)

spyAllOn: aBlock cutoff: aNumber

        | node result |
        node := self new.
        node reportOtherProcesses: true. "Irrelevant in this case. All processes  
will be reported on their own."
        result := node spyAllEvery: self defaultPollPeriod on: aBlock.
        (CodeHolder new contents: (String streamContents: [:s | node report: s  
cutoff: aNumber; close]))
                openLabel: 'Spy Results' wrap: false.
        ^ result


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #18 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

ok, I see :))



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #19 on issue 4573 by [hidden email]: Should deprecate  
TimeProfileBrowser
http://code.google.com/p/pharo/issues/detail?id=4573

This means that one of these days it would be good to have a subclass of  
AbstractTool that replace CodeHolder :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker