Issue 4576 in pharo: MessageNames should be deprecated

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Milestone-1.4 Difficulty-Easy

New issue 4576 by [hidden email]: MessageNames should be deprecated
http://code.google.com/p/pharo/issues/detail?id=4576

Now that Benjamin van ryseghem wrote a new Finder. We can really remove  
MessageNames from the system.
There is still one reference

PasteUpMorph>>findAMessageNamesWindow: evt
        "Locate a MessageNames tool, open it, and bring it to the front.  Create  
one if necessary"

        self findAWindowSatisfying:
                [:aWindow | aWindow model isKindOf: MessageNames] orMakeOneUsing:  
[MessageNames new inMorphicWindowLabeled: 'Message Names']


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #1 on issue 4576 by [hidden email]: MessageNames should be  
deprecated
http://code.google.com/p/pharo/issues/detail?id=4576

Pharo image: Pharo1.4a#14090
Virtual machine used: Squeak4.1 of 17 April 2010 [latest update: #9957]
Platform Name: unix

deprecate MessageNames.
rename findAMessageNamesWindow to findAFinderWindow.
change defaultDesktopCommandKeyTriples, see postscript.


Scenario Open a new Finder
- close all windows
- set focus on desktop
- press Alt + Shift + w
Expected Result:
a new finder should appear.

Scenario Open an existing Finder
- open a Finder
- minimize it
- set focus on desktop
- press Alt + Shift + w
Expected Result:
the minimized finder should appear.

could someone review the changeset, please? especially  
PasteUpMorph>>findAFinderWindow


Attachments:
        issue-4576-MessageNames-should-be-deprecated.1.cs  2.9 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4576 by [hidden email]: MessageNames should be  
deprecated
http://code.google.com/p/pharo/issues/detail?id=4576

Pharo image: Pharo1.4a#14090
Virtual machine used: Squeak4.1 of 17 April 2010 [latest update: #9957]
Platform Name: unix

deprecate MessageNames.
delete findAMessageNamesWindow
change defaultDesktopCommandKeyTriples, see postscript.
add ToolRegistry>>openFinder.

Scenario Open a new Finder
- close all windows
- set focus on desktop
- press Alt + Shift + w
Expected Result:
a new finder should appear.

Scenario Open an existing Finder
- open a Finder
- minimize it
- set focus on desktop
- press Alt + Shift + w
Expected Result:
the minimized finder should appear.



Attachments:
        issue-4576-MessageNames-should-be-deprecated.1.cs  2.7 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4576 by [hidden email]: MessageNames should be  
deprecated
http://code.google.com/p/pharo/issues/detail?id=4576

thanks this is great to get some help from that side.
I will have a look.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4576 by [hidden email]: MessageNames should be  
deprecated
http://code.google.com/p/pharo/issues/detail?id=4576

forget the scenario "Open an existing Finder" because im always opening a  
new finder.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #5 on issue 4576 by [hidden email]: MessageNames should be  
deprecated
http://code.google.com/p/pharo/issues/detail?id=4576

in 14096


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker