Issue 4609 in pharo: Syntax highlighting broken

Comment #20 on issue 4609 by renggli: Syntax highlighting broken
http://code.google.com/p/pharo/issues/detail?id=4609

> PluggableTextMorph has 5 instance variables which seems to be for styling:
> I understand why we have styler and styled but why do we have also  
> unstyledAcceptText, nullStyler and
> shoutedStyler inst vars ?

I don't understand these changes. I suggest to get rid of NullStyler and  
friends, restore the old PluggableShoutMorph and use an old version of the  
Shout package. Then we can introduce a  
setting 'preferredPluggableMorphClass' what will either instantiate the  
unstyled morph (by default) or one that is added by a styler (as before).

> also, what is OBPluggableShoutTextMorph for ?
> Normally this class should not exist, right ?

OB uses OBPluggableShoutTextMorph when Shout is loaded, otherwise  
OBPluggableTextMorph.

> Shout should call #shoutAboutToStyle: whenever a text is modified, ok but  
> from where is should be called ?

Have a look at PluggableShoutMorph in an older version of Shout. There is  
quite some support code there.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #21 on issue 4609 by [hidden email]: Syntax highlighting broken
http://code.google.com/p/pharo/issues/detail?id=4609

Well, I don't think PluggableShoutMorph is a good solution and I prefer the  
styler inst var solution...

I think I've removed all bad dependencies from models to views, no more  
textMorph inst var in StringHolder ...
I've also cleaned PluggableTextMorph.
Styling is no more directly set from models and I've implemented few  
#shoutAboutToStyle:.
Take a fresh 1.3. I've not tried to re-load it (time to sleep now), hope it  
is ok.
Could you make a try and tell me ?
There are still some problems with Monticello, I will fix it soon.


Attachments:
        shout-fix-slice.zip  2.8 MB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #22 on issue 4609 by renggli: Syntax highlighting broken
http://code.google.com/p/pharo/issues/detail?id=4609

Excellent, than's a lot for looking into this. It looks very cool. You  
removed a lot of ugly code.

A quick code review:

- No changes in: AST-Core, Collections-Streams
- I don't see why there is a NullStyler as well as you can can set #styled:  
to true/false? Shouldn't the system have a default styler-class that is set  
when styling is enabled on a morph, and the NullStyler is set when it is  
disabled?
- PluggableTextMorph>>#okToStyle and #shoutEnabled should be part of the  
Shout package, not of Morphic.
- Not sure what PluggableTextMorph>>workspace: and #environemnt: are for.  
Again this seems to be something of Shout, not Morphic.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #23 on issue 4609 by [hidden email]: Syntax highlighting broken
http://code.google.com/p/pharo/issues/detail?id=4609

I agree with all your points.
I try too remove PluggableTextMorph>>workspace: and #environemnt:.
especially all #workspace: that we have also in shout that looks really  
strange to me.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #24 on issue 4609 by [hidden email]: Syntax highlighting broken
http://code.google.com/p/pharo/issues/detail?id=4609

Last fixes.
finally, let #workspace: of shout untouched and #okToStyle + #shoutEnabled  
in Morphic because morphic need them to work properly if shout is not  
loaded.

To test in a (full) pharo 1.3 image:  
SLICE-Issue-4609-Syntax-highlighting-broken-AlainPlantec.4

To integrate into pharo core 1.3:  
SLICE-Issue-4609-Syntax-highlighting-broken-AlainPlantec.5

since squeaksource is down, for now, I can't update OB-Shout,  
ScriptManager-Core and Shout packages.

next step: a slice for 1.4





_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #25 on issue 4609 by [hidden email]: Syntax highlighting  
broken
http://code.google.com/p/pharo/issues/detail?id=4609

**Thanks** alain. I will really look at it tomorrow because I want to  
understand.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: -[hidden email] [hidden email]

Comment #26 on issue 4609 by [hidden email]: Syntax highlighting  
broken
http://code.google.com/p/pharo/issues/detail?id=4609

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #27 on issue 4609 by [hidden email]: Syntax highlighting broken
http://code.google.com/p/pharo/issues/detail?id=4609

For 1.4:
SLICE-Issue-4609--Syntax-highlighting-broken-FOR-14-AlainPlantec.1
In addition, you will enjoy shout with DiffMorph

For 1.3, wait until squeaksource is up again


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude
        Labels: Importance-High

Comment #28 on issue 4609 by [hidden email]: Syntax highlighting  
broken
http://code.google.com/p/pharo/issues/detail?id=4609

Ok let me know when you publish for 1.3.
I'm integrating the changes in 1.4.
I cannot merge because I cannot find Finder-StephaneDucasse.58 any idea  
where this guys can be
I added squeaksource/PharoTaskForces, squeaksource/Pharo


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #29 on issue 4609 by [hidden email]: Syntax highlighting  
broken
http://code.google.com/p/pharo/issues/detail?id=4609

I added them to Finder itself

an OrderedCollection(a MCHttpRepository(http://ss3.gemstone.com/ss/Pharo14)  
a MCHttpRepository(http://www.squeaksource.com/PharoInbox/) a  
MCHttpRepository(http://www.squeaksource.com/PharoTreatedInbox) a  
MCHttpRepository(http://www.squeaksource.com/Pharo))

in http://www.squeaksource.com/Pharo I see Finder.StephaneDucasse.58.mcz

So I copied it manually to http://ss3.gemstone.com/ss/Pharo14
I could not get why it was not found.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #30 on issue 4609 by [hidden email]: Syntax highlighting  
broken
http://code.google.com/p/pharo/issues/detail?id=4609

retrying since I got 131 conflicts..... :(


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #31 on issue 4609 by [hidden email]: Syntax highlighting  
broken
http://code.google.com/p/pharo/issues/detail?id=4609

Alain in fact I cannot find  
SLICE-Issue-4609--Syntax-highlighting-broken-FOR-14-AlainPlantec.1
I just get SLICE-Issue-4609-Syntax-highlighting-broken-AlainPlantec.6
so could you republish your slices or let me know?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #32 on issue 4609 by [hidden email]: Syntax highlighting broken
http://code.google.com/p/pharo/issues/detail?id=4609

I've found it in the ss3 repo.
I've just re-tried and did'nt get any conflict.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #33 on issue 4609 by [hidden email]: Syntax highlighting  
broken
http://code.google.com/p/pharo/issues/detail?id=4609

Ok Alain for 1.3 could you publish the version in  
squeaksource.com/PharoInbox?
Or should I just take the  
SLICE-Issue-4609-Syntax-highlighting-broken-AlainPlantec.6.

In 14111 I integrated the "For-14"


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #34 on issue 4609 by [hidden email]: Syntax highlighting broken
http://code.google.com/p/pharo/issues/detail?id=4609

Since I can't save in squeaksource.com/PharoInbox (write protected ?)
Here is a shout-fixes directory with the slice for 1.3 core

Lukas, I've saved OB-Shout in squeaksource.

ProfStef-Core and Sout are save in their respective squeaksource repo.
I was unable to save ScriptManager (write protected repo) so, the new  
version is also in the attached shout-fixes directory.


Attachments:
        shout-fixes.zip  2.6 MB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #35 on issue 4609 by [hidden email]: Syntax highlighting broken
http://code.google.com/p/pharo/issues/detail?id=4609

Take  SLICE-Issue-4609-Syntax-highlighting-broken-FOR-13-AlainPlantec.5
in the attached shout-fixes zipped directory.
"not style" is now the default


Attachments:
        shout-fixes.zip  3.9 MB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.4

Comment #36 on issue 4609 by [hidden email]: Syntax highlighting  
broken
http://code.google.com/p/pharo/issues/detail?id=4609

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #37 on issue 4609 by [hidden email]: Syntax highlighting  
broken
http://code.google.com/p/pharo/issues/detail?id=4609

I uploaded the Slice to the old inbox for 1.3

Now when I merge, I get 22 conflicts...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Started

Comment #38 on issue 4609 by [hidden email]: Syntax highlighting  
broken
http://code.google.com/p/pharo/issues/detail?id=4609

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #39 on issue 4609 by [hidden email]: Syntax highlighting broken
http://code.google.com/p/pharo/issues/detail?id=4609

and with the shout-fixes.zip that is attached in the previous comment ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker