Issue 4617 in pharo: More error tolerant startup

Status: New
Owner: ----

New issue 4617 by [hidden email]: More error tolerant startup
http://code.google.com/p/pharo/issues/detail?id=4617

Add some error catching to avoid that broken startup scripts can prevent  
crucial parts from starting up.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ReviewNeeded
        Cc: [hidden email]
        Labels: Milestone-1.4

Comment #1 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

igor can you have a look


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Accepted
        Labels: Type-Bug

Comment #2 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

SLICE-Issue-4617-More-error-tolerant-startup-Camillobruni.1

Igor add this to your todo list.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #4 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #5 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

this has been integrated by igor and me


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

this has been integrated by igor and me


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

I just tried to backport the slice to pharo1.3 #13315, but without success!

What I did:
- I put a 1/0 into a startUp: method
- save and quit
- open -> the image immediately quits

Is this the NonInteractiveUIManager that still quits the image?

I attached the stack trace and my backported changes from your slice.

Attachments:
        startuperror.txt  31.9 KB
        startuperrors4617backported13.1.cs  3.6 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

maybe try to launch the image with a script that overwrites MCWorkingCopy  
class>>#startUp:?

MCWorkingCopy class compile: ' startUp: resuming "for now do not do  
anything"'

might get you a bit further..


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

Let us first be clear about what the goal of #4617 is. I thought the whole  
point of it was to catch the errors during startup! I came to this  
conclusion by reading this page, the mailing list and #5045.
Am I wrong?

Camillo, can you tell me how to launch the image with a script, as  
suggested? This would indeed be a useful workaround but I don't know how to  
do this.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

the goal is to allow for as much initialization as possible:
- in the startup handler loop catch all the errors and resignal them later
- the same for the deferred startup handlers

finally once the image has started up signal a StartupError with a  
reference to all the previously caught errors.

Of course this will still quit the image if in non-interactive mode since  
you will pop-up the debugger. There might be a possibility to implement a  
complete Debugger à la gdb for the command line, but IMO that's a different  
story.

for the script you will just do the following:

/Path/to/Your/VM foo.image foo.script

and in the script:
~~~~~~~~~~~~~~~~~~~~~~
MCWorkingCopy class compile: ' startUp: resuming "for now do not do  
anything"'
~~~~~~~~~~~~~~~~~~~~~~


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: NextActionNeeded
        Labels: Milestone-1.3 Importance-High

Comment #11 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

I am so sorry but the solution with the script does not work! It is no  
surprise, because I assume the script is executed after all other startup  
code.

"Of course this will still quit the image if in non-interactive mode since  
you will pop-up the debugger."
I am not in non-interactive mode. Well, let's say, not on purpose. I am in  
a dev image! And I am not willing to lose my whole images every 2 weeks.

So I report this as a major bug in pharo1.3.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

I think the `on: Object do: [` won't work... AFAIK we changed that in  
another bug report


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

Ok, thank you for this hint. Why does `on: Object do: [` not work? Can you  
find out which bug report that was?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

`on:Object do: ` is not supported by the VM.
and I don't remember where we changed the code..


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.4

Comment #15 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

I remove the 1.4 tag from this because I think that this is fixed there?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #16 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

Issue 5045 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #17 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

@Marcus: I have not tested it in 1.4, but if anyone else can confirm that  
it works with 1.4, it is ok to remove that tag.

@Camillo/all: What do you propose that should be done next to solve this  
issue?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #18 on issue 4617 by [hidden email]: More error tolerant  
startup
http://code.google.com/p/pharo/issues/detail?id=4617

I would say simply reimplement the same thing I did and use `on: Error do:  
[` did you try that?
Or try to implement issue 5290 in 1.3, but I guess it's too much work.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #19 on issue 4617 by [hidden email]: More error tolerant startup
http://code.google.com/p/pharo/issues/detail?id=4617

I've backportet Camillo's changes to the startup error handling. We will be  
testing the backport for a bit and when it works out I'll post the slice.

Thanks Camillo for the help.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker