Issue 4636 in pharo: allowUnderscoreAsAssignment broken

Status: Accepted
Owner: marianopeck
CC: [hidden email],  [hidden email]
Labels: Milestone-1.4

New issue 4636 by marianopeck: allowUnderscoreAsAssignment broken
http://code.google.com/p/pharo/issues/detail?id=4636

Tried in Pharo 1.4.

Scanner allowUnderscoreAsAssignment   ->> true.

I then try to compile:

testUnderscore
     | a |
     a _ 'a'.
     self assert: a equals: 'a'

And I get:

testUnderscore
     | a |
     a _  Nothing more expected ->'a'.
     self assert: a equals: 'a'


Igor said:

Ouch.. Someone (actually Ben)
has moved initializeTypeTable to String...

----

at least, if you doing refactorings like that, you should also modify
other places.
There should be no two implementations of initializeTypeTable. We
don't need two.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Bug

Comment #1 on issue 4636 by [hidden email]:  
allowUnderscoreAsAssignment broken
http://code.google.com/p/pharo/issues/detail?id=4636

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4636 by [hidden email]:  
allowUnderscoreAsAssignment broken
http://code.google.com/p/pharo/issues/detail?id=4636

When changing the allow underscore preference, it is needed to send
String allowUnderscore or String denyUnderscore accordingly.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4636 by [hidden email]: allowUnderscoreAsAssignment  
broken
http://code.google.com/p/pharo/issues/detail?id=4636

what is the status of Scanner class>>TypeTable then ?
Scanner is a more appropriate place for that kind of stuf, no ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4636 by [hidden email]:  
allowUnderscoreAsAssignment broken
http://code.google.com/p/pharo/issues/detail?id=4636

good question! I first tryied reinitializing it, which changed $_ from  
#xLetter to #leftArrow, but didn't affect the parsing at all. Then,  
reinitializing the String TypeTable solved the problem. Probably it was  
left over by error if not for compatibility.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #5 on issue 4636 by marianopeck: allowUnderscoreAsAssignment broken
http://code.google.com/p/pharo/issues/detail?id=4636

So...here is the fix.

Name: SLICE-Issue-4636--allowUnderscoreAsAssignment-broken--mariano.1
Author: mariano
Time: 30 September 2011, 3:46:16 pm
UUID: 44f4b812-e0aa-4417-9241-dd130ee41619
Ancestors:
Dependencies: Compiler-mariano.299

Fix to issue 4636


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #6 on issue 4636 by [hidden email]:  
allowUnderscoreAsAssignment broken
http://code.google.com/p/pharo/issues/detail?id=4636#c6

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #7 on issue 4636 by [hidden email]:  
allowUnderscoreAsAssignment broken
http://code.google.com/p/pharo/issues/detail?id=4636#c7

This Issue has been checked by Ulysse the Monkey
       
6233 tests passed in 00:01:22s:
===============================
        CollectionsTests-Arrayed (562)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (590)
        CollectionsTests-Support (12)
        CollectionsTests-Text (40)
        CollectionsTests-Unordered (1977)
        CollectionsTests-Weak (751)
        CompilerTests (60)
        KernelTests-Chronology (574)
        KernelTests-Classes (59)
        KernelTests-Exception (2)
        KernelTests-Methods (177)
        KernelTests-Numbers (232)
        KernelTests-Objects (85)
        KernelTests-Pragmas (3)
        KernelTests-Processes (22)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (77)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-4636--allowUnderscoreAsAssignment-broken--mariano.1 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-1.4-14180-a on Croquet Closure Stack VM  
[StackInterpreter VMMaker-oscog-EstebanLorenzano.109] 21.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #8 on issue 4636 by [hidden email]:  
allowUnderscoreAsAssignment broken
http://code.google.com/p/pharo/issues/detail?id=4636

in 14181


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker