Issue 4642 in pharo: FinderUI>>compileSource: aString notifying: aController

Status: Accepted
Owner: ----
Labels: Milestone-1.3

New issue 4642 by renggli: FinderUI>>compileSource: aString notifying:  
aController
http://code.google.com/p/pharo/issues/detail?id=4642

Very strange Smalltalk code, strange that it compiles:

      ##clearUserEdits

Makes me wonder if we could somehow improve the review process?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4642 by [hidden email]: FinderUI>>compileSource:  
aString notifying: aController
http://code.google.com/p/pharo/issues/detail?id=4642

I don't know the exact specs of st but to me this looks pretty valid though  
here most probably a bug.

... in the same direction as $$


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.4

Comment #2 on issue 4642 by renggli: FinderUI>>compileSource: aString  
notifying: aController
http://code.google.com/p/pharo/issues/detail?id=4642

Parsing of symbols is totally strange Squeak based compilers. All the  
following variations

     ##clearUserEdits
     ######clearUserEdits
     #    #     #  clearUserEdits
     # "crap"  # "syntax"  clearUserEdits

are accepted and (unbelievably) used in code. According to ANSI and sane  
human reasoning only the following two variations should be accepted:

     #clearUserEdits
     #'clearUserEdits'

I don't see anything wrong with $$, this is just the Character $.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4642 by [hidden email]: FinderUI>>compileSource:  
aString notifying: aController
http://code.google.com/p/pharo/issues/detail?id=4642

I agree and we should keep ## for possible introduction of new syntax.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4642 by [hidden email]: FinderUI>>compileSource:  
aString notifying: aController
http://code.google.com/p/pharo/issues/detail?id=4642

See Compiler-ul.202 in Squeak Trunk for change needed to reject  
##srsBusiness & friends.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4642 by [hidden email]: FinderUI>>compileSource:  
aString notifying: aController
http://code.google.com/p/pharo/issues/detail?id=4642

Ah I interpreted it wrongly.. indeed the results as they are now are  
totally stupid.
But I think ##foo should be handled in the exact same way as $$

#bla  => 'bla' asSymbol
## => '#' asSymbol
##bla => '#bla' asSymbol


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4642 by [hidden email]: FinderUI>>compileSource:  
aString notifying: aController
http://code.google.com/p/pharo/issues/detail?id=4642

Maybe a new bug entry not related to the Finder should be opened :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #7 on issue 4642 by [hidden email]: FinderUI>>compileSource:  
aString notifying: aController
http://code.google.com/p/pharo/issues/detail?id=4642

Fix for Finder code attached (for both 1.3 and 1.4).

The problem of the compiler accepting strange #### is there since 10 years,  
and I do not think that this
is something to be fixed in 1.3... and should get it's own bug report.


Attachments:
        FixStrange.1.cs  625 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4642 by [hidden email]: FinderUI>>compileSource:  
aString notifying: aController
http://code.google.com/p/pharo/issues/detail?id=4642

in 13300

TODO: 1.4


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #9 on issue 4642 by [hidden email]: FinderUI>>compileSource:  
aString notifying: aController
http://code.google.com/p/pharo/issues/detail?id=4642

in 14110


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker