Issue 4643 in pharo: Inspector>>fieldListMenu: aMenu

Status: Accepted
Owner: ----
Labels: Milestone-1.3

New issue 4643 by renggli: Inspector>>fieldListMenu: aMenu
http://code.google.com/p/pharo/issues/detail?id=4643

Very strange Smalltalk code, strange that it compiles. Also probably a bug  
because we have #. symbols in the arrays then:

fieldListMenu: aMenu
        "Arm the supplied menu with items for the field-list of the receiver"

        aMenu addStayUpItemSpecial.

        aMenu addList: #(
                ('Inspect (i)' inspectSelection. nil. #smallInspectItIcon)
                ('Explore (I)' exploreSelection. nil. #smallInspectItIcon)).

Makes me wonder if we could somehow improve the review process?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.4

Comment #1 on issue 4643 by [hidden email]:  
Inspector>>fieldListMenu: aMenu
http://code.google.com/p/pharo/issues/detail?id=4643

ouch.
Ideally I would love to have a process that automatically run some rules on  
fixes.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude
        Labels: Type-Bug

Comment #2 on issue 4643 by [hidden email]:  
Inspector>>fieldListMenu: aMenu
http://code.google.com/p/pharo/issues/detail?id=4643

(No comment was entered for this change.)

Attachments:
        Fix.1.cs  1.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4643 by renggli: Inspector>>fieldListMenu: aMenu
http://code.google.com/p/pharo/issues/detail?id=4643

I don't see why the proposed fix uses dynamic arrays? This is not necessary  
because the menu specification is just a literal.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4643 by [hidden email]:  
Inspector>>fieldListMenu: aMenu
http://code.google.com/p/pharo/issues/detail?id=4643

in 13301 (using #() not #{})


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.3

Comment #5 on issue 4643 by [hidden email]:  
Inspector>>fieldListMenu: aMenu
http://code.google.com/p/pharo/issues/detail?id=4643

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed
        Labels: Milestone-1.3

Comment #6 on issue 4643 by [hidden email]:  
Inspector>>fieldListMenu: aMenu
http://code.google.com/p/pharo/issues/detail?id=4643

in 14121


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker