Issue 4663 in pharo: Failing Test: SmalltalkImageTest>>#testImageName

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.4 Type-Bug

New issue 4663 by [hidden email]: Failing Test:  
SmalltalkImageTest>>#testImageName
http://code.google.com/p/pharo/issues/detail?id=4663

Tests.System.SmalltalkImageTest.testImageName


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4663 by [hidden email]: Failing Test:  
SmalltalkImageTest>>#testImageName
http://code.google.com/p/pharo/issues/detail?id=4663

This is probably related to the changes made by camillo and igor and  
related to FS
path was before returning a full name...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Started

Comment #2 on issue 4663 by [hidden email]: Failing Test:  
SmalltalkImageTest>>#testImageName
http://code.google.com/p/pharo/issues/detail?id=4663

I think the problem is just that the change in the test goes from

self assert: path = Smalltalk imagePath
to
self assert: path = Smalltalk vm imagePath

path is a directory.  vm imagePath returns self getSystemAttribute: 1 which  
is the full path.

So i'm not sure the intention. If all the references to Smalltalk imagePath  
got rewrote to Smalltalk vm imagePath then the result is unexpected. I  
guess one method is needed to answer the dir and one the full path?

--Mike


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4663 by [hidden email]: Failing Test:  
SmalltalkImageTest>>#testImageName
http://code.google.com/p/pharo/issues/detail?id=4663

Yes this should be something like that.
We should check tomorrow. We will have clean that part.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4663 by [hidden email]: Failing Test:  
SmalltalkImageTest>>#testImageName
http://code.google.com/p/pharo/issues/detail?id=4663

Name:  
SLICE-Issue-4663-Failing-Test-SmalltalkImageTest-testImageName-MikeRoberts.2
Author: MikeRoberts
Time: 21 August 2011, 2:56:39 pm
UUID: 4cc14c4c-698f-40bd-861f-638398d56449
Ancestors:  
SLICE-Issue-4663-Failing-Test-SmalltalkImageTest-testImageName-MikeRoberts.1
Dependencies: Files-MikeRoberts.ducasse.219, FreeType-MikeRoberts.557,  
Tests-MikeRoberts.312

Changes senders of
        Smalltalk vm imagePath
back to
        Smalltalk imagePath
       
Senders expected the directory containing the image file, but instead got  
the full image filename.  In the future we need to split the API so it is  
clear you ask for the directory containing the image file, or the full file  
path.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #5 on issue 4663 by [hidden email]: Failing Test:  
SmalltalkImageTest>>#testImageName
http://code.google.com/p/pharo/issues/detail?id=4663

in 14104


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker