Issue 4664 in pharo: SystemAnnouncement is ready for integration

Status: FixToInclude
Owner: [hidden email]
Labels: Milestone-1.4

New issue 4664 by [hidden email]: SystemAnnouncement is ready for  
integration
http://code.google.com/p/pharo/issues/detail?id=4664

Igor did a pass on the code so now it is ready for integration.
The package is available in SystemAnnouncement in PharoTaskForces.

The tools could then start to register to this announcer instead of  
SystemChangeNotifier.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4664 by [hidden email]: SystemAnnouncement is ready  
for integration
http://code.google.com/p/pharo/issues/detail?id=4664

If I see the right package, the names could use need changing;
- Drop Announcement from the end of all non-abstract announcement names.
- Drop System from all names.
- Change Internal to AboutTo...

So you have

InternalSystemClassRenamedAnnouncement -> AboutToRenameClass
SystemClassRenamedAnnouncement -> ClassRenamed

This makes the handlers read much more natural.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4664 by [hidden email]: SystemAnnouncement is ready  
for integration
http://code.google.com/p/pharo/issues/detail?id=4664

Other than that: Awesome! True announcements from the system about what  
it's doing!
Woot!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4664 by [hidden email]: SystemAnnouncement is  
ready for integration
http://code.google.com/p/pharo/issues/detail?id=4664

Thanks the internal is that because people should not use them.
For the name yes we are open to better one so do not hesitate to propose  
some of them.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4664 by [hidden email]: SystemAnnouncement is  
ready for integration
http://code.google.com/p/pharo/issues/detail?id=4664

Henrik did you renamed the classes?
I will include the package now in 1.4 and we can change the names once it  
is loaded.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #5 on issue 4664 by [hidden email]: SystemAnnouncement is  
ready for integration
http://code.google.com/p/pharo/issues/detail?id=4664

in 14114


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4664 by [hidden email]: SystemAnnouncement is ready  
for integration
http://code.google.com/p/pharo/issues/detail?id=4664

but we should change names before we start using them, otherwise it will  
cost a lot of refactoring again


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4664 by [hidden email]: SystemAnnouncement is ready  
for integration
http://code.google.com/p/pharo/issues/detail?id=4664

Yes.
I'll look into it what remains tonight.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker