Issue 4683 in pharo: Code completion breaks search fields

Status: New
Owner: ----

New issue 4683 by [hidden email]: Code completion breaks search  
fields
http://code.google.com/p/pharo/issues/detail?id=4683

In some search fields, an error happens during typing because of code  
completion. E.g. in the MessageNames-Browser, as in the attached stack  
trace.

Steps to reproduce:
1. select "a" and open the MessageNames browser with cmd+shift+w
2. type "r" next to the "a" (this step will differ in your image because  
the completion tables are different)
3. You get the error

Pharo image: Pharo
Pharo core version: Pharo1.2.2
Virtual machine used: Mac Squeak 4.2.2beta1U
Class browser used: OBSystemBrowserAdaptor


Attachments:
        stack_search_method_error-1.txt  25.3 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.2.2

Comment #1 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

The attached fix makes that code completion is only done for  
SmalltalkEditors and not for all TextEditors.

Attachments:
        fix_searchbug.1.cs  949 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed
        Cc: [hidden email]

Comment #3 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

Tx we will have to sync with alain because I do not know how we will handle  
1.2.3
For sure we will try to add the fixes in 1.3 and 1.4


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.3 Milestone-1.4

Comment #4 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

Alain is looking at the textMorph and shout problems


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Started

Comment #5 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.2.2

Comment #6 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.4

Comment #7 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

Not a but in 1.4


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Bug

Comment #8 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #9 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

This is fixed in 1.3


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4683 by [hidden email]: Code completion  
breaks search fields
http://code.google.com/p/pharo/issues/detail?id=4683

I still have the same problem in 1.3 (13315)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

alain could you have a look when you have some time?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Accepted

Comment #12 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

It seems to be related to completion, not shout.
I will have a look



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

Ok sorry :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed
        Labels: Milestone-1.4

Comment #14 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

attached a fix for 1.3.
(regarding the fix that was proposed previously, don't use  
#isSmalltalkEditor but directly ask the editor to do the right thing)

for 1.4
SLICE-Issue-4683-Code-completion-breaks-search-fields-AlainPlantec.1

Attachments:
        codeCompletionAround.1.cs  4.8 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #15 on issue 4683 by [hidden email]: Code completion  
breaks search fields
http://code.google.com/p/pharo/issues/detail?id=4683

Thanks!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #16 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

in 13317

TODO: 1.4


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #17 on issue 4683 by [hidden email]: Code completion breaks  
search fields
http://code.google.com/p/pharo/issues/detail?id=4683

in 14205


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker