Issue 4688 in pharo: progress bar disappears on image save

Status: New
Owner: ----

New issue 4688 by [hidden email]: progress bar disappears on image  
save
http://code.google.com/p/pharo/issues/detail?id=4688

The progress bar disappears when you interrupt and save. It does not appear  
again.

Pharo image: Pharo
Pharo core version: Pharo1.2.2
Virtual machine used: Mac Squeak 4.2.2beta1U
Class browser used: OBSystemBrowserAdaptor

Steps to reproduce:
1. Run:
(1 to: 10) do: [ :each | (Delay forSeconds: 1) wait ]  
displayingProgress: 'test'
2. In the middle interrupt
3. Save the image
4. The progress bar varnishes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4688 by [hidden email]: progress bar  
disappears on image save
http://code.google.com/p/pharo/issues/detail?id=4688

Fix (includes also 4689)

Attachments:
        fix_progressbar.txt  4.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4688 by [hidden email]: progress bar disappears  
on image save
http://code.google.com/p/pharo/issues/detail?id=4688

Tx


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #3 on issue 4688 by [hidden email]: progress bar disappears  
on image save
http://code.google.com/p/pharo/issues/detail?id=4688

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ReviewNeeded
        Labels: Milestone-1.4

Comment #4 on issue 4688 by [hidden email]: progress bar disappears  
on image save
http://code.google.com/p/pharo/issues/detail?id=4688

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Bug

Comment #5 on issue 4688 by [hidden email]: progress bar disappears  
on image save
http://code.google.com/p/pharo/issues/detail?id=4688

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #6 on issue 4688 by marianopeck: progress bar disappears on image  
save
http://code.google.com/p/pharo/issues/detail?id=4688

Thanks. I tested and it works.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #7 on issue 4688 by [hidden email]: progress bar disappears  
on image save
http://code.google.com/p/pharo/issues/detail?id=4688

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email] [hidden email]

Comment #8 on issue 4688 by marianopeck: progress bar disappears on image  
save
http://code.google.com/p/pharo/issues/detail?id=4688

Hi. I have just checked the code. Basically in

  UITHeme >> startUp
        "Reset the system progress morph in case of font changes."

        SystemProgressMorph reset

He removes such reset. Now, what about what the comment says "in case of  
font changes" ?  do you know?

And also I saw some changes like one that the progress bar was re-centered  
in the top left of the display instead than in the middle. Was this on  
purpose ?



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 4688 by [hidden email]: progress bar  
disappears on image save
http://code.google.com/p/pharo/issues/detail?id=4688

Top left instead of center was on purpose, because if it is in the middle,  
it is hard to work at the same time. Imagine you have a process that takes  
a few hours.
See also Issue 4690. I just noticed that the issue I mentioned above was  
the wrong one, it should have been 4690, "progress bar position should be  
configurable", sorry for that!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4688 by marianopeck: progress bar disappears on image  
save
http://code.google.com/p/pharo/issues/detail?id=4688

THanks Andreas. And what about the comment it says of "in case of hange  
fonts". We don't care?  it is not still teh case?




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 4688 by [hidden email]: progress bar  
disappears on image save
http://code.google.com/p/pharo/issues/detail?id=4688

I don't know, maybe it's not so nice to just ignore that comment, but I  
personally would not care, because I can't image a broken (?) font to be  
that dangerous.

I guess the use case for that comment is when you change the UITheme.  
Maybe "SystemProgressMorph reset" was not originally meant to delete the  
progress bar, but just to repaint it, then it would have made sense.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #12 on issue 4688 by marianopeck: progress bar disappears on image  
save
http://code.google.com/p/pharo/issues/detail?id=4688

So, I have checked the code and it is ok, but I needed to merge with latest  
changes of progressMorph. I have submitted a new slice in inbox. This  
changes 2 things:
- progress bar is now placed in the top left of the screen
- it does not desapears in startUp.

Now, since UITheme class >> #startUp is removed, I think we can remove it  
from startUpList:

Smalltalk removeFromStartUpList: UITheme.



Name:  
SLICE-Issue-4688-progress-bar-disappears-on-image-save-MarianoMartinezPeck.1
Author: MarianoMartinezPeck
Time: 16 December 2011, 11:36:32 am
UUID: 40201e09-fb6b-4b94-8990-b648fb8e1d46
Ancestors:
Dependencies: Morphic-MarianoMartinezPeck.1056,  
Polymorph-Widgets-MarianoMartinezPeck.553

Fix




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #13 on issue 4688 by [hidden email]: progress bar disappears  
on image save
http://code.google.com/p/pharo/issues/detail?id=4688

in 14263


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #14 on issue 4688 by marianopeck: progress bar disappears on image  
save
http://code.google.com/p/pharo/issues/detail?id=4688

Thanks Marcus. I think you forget to do:
Smalltalk removeFromStartUpList: UITheme.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: -[hidden email] -[hidden email] -[hidden email]  
[hidden email]

Comment #15 on issue 4688 by marianopeck: progress bar disappears on image  
save
http://code.google.com/p/pharo/issues/detail?id=4688

Stef, can you check?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #16 on issue 4688 by [hidden email]: progress bar disappears  
on image save
http://code.google.com/p/pharo/issues/detail?id=4688

Ok I will do it.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #17 on issue 4688 by [hidden email]: progress bar disappears  
on image save
http://code.google.com/p/pharo/issues/detail?id=4688

Done in 14269


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker