Status: New
Owner: ---- New issue 4689 by [hidden email]: MessageTally defect http://code.google.com/p/pharo/issues/detail?id=4689 MessageTally does not work for methods that wait for something (the waiting/idle time is summed up in a seperate tree, so you don't know which method had to wait so long). My workaraound is to load the Squeak-MessageTally into Pharo (see attachment). Pharo image: Pharo Pharo core version: Pharo1.2.2 Virtual machine used: Mac Squeak 4.2.2beta1U Class browser used: OBSystemBrowserAdaptor Steps to reproduce: 1. install the following code: Object>theBigMethod 1 to: 100 do: [:i | self aBusyMethod. self aWaitingMethod ] Object>aBusyMethod (1 to: 10000) do: [:i | (1 to: 10000) atRandom ] Object>aWaitingMethod (1 to: 10) do: [:i | (Delay forMilliseconds: 10) wait ] 2. execute: MessageTally spyOn: [ 5 theBigMethod ] 3. Compare the output of a pharo and a squeak image Output: PHARO (bad): 14716 tallies, 14795 msec. Tree Process: (40s) 587726848: nil 19.5% {2882ms} SmallInteger(Object)>>aBusyMethod |14.3% {2110ms} Interval(Collection)>>atRandom | |8.4% {1245ms} Interval(SequenceableCollection)>>atRandom: | | |5.1% {753ms} Random>>nextInt: | | | |2.7% {397ms} Random>>next | | | | 1.7% {252ms} Random>>nextValue | | | | 1.0% {153ms} Float(Number)>>quo: | | |1.6% {240ms} Interval>>at: | | |1.1% {160ms} Interval>>size | |2.4% {348ms} Semaphore>>critical: | | |1.3% {197ms} primitives | | |1.0% {151ms} BlockClosure>>ensure: | |1.4% {203ms} primitives | |1.2% {175ms} Interval class(Collection class)>>randomForPicking |3.2% {478ms} SmallInteger(Number)>>to: | |2.1% {308ms} Interval class>>from:to:by: | | |1.2% {178ms} Interval>>setFrom:to:by: | |1.1% {170ms} primitives |1.1% {165ms} Interval>>do: 6.5% {967ms} SmallInteger(Object)>>aWaitingMethod 6.5% {967ms} Delay>>wait 6.4% {944ms} primitives Leaves 6.4% {944ms} Delay>>wait 1.9% {283ms} Interval>>size 1.4% {203ms} Interval(Collection)>>atRandom 1.3% {197ms} Semaphore>>critical: 1.2% {178ms} Interval>>setFrom:to:by: 1.2% {175ms} Interval class(Collection class)>>randomForPicking 1.1% {170ms} SmallInteger(Number)>>to: 1.1% {165ms} Interval>>do: 1.0% {153ms} Float(Number)>>quo: 1.0% {151ms} BlockClosure>>ensure: SQUEAK (good): 13811 tallies, 13889 msec. Tree 100.0% {13889ms} SmallInteger(Object)>>theBigMethod 72.7% {10097ms} SmallInteger(Object)>>aWaitingMethod |72.7% {10097ms} Delay>>wait | 72.5% {10070ms} primitives 27.3% {3792ms} SmallInteger(Object)>>aBusyMethod 22.2% {3083ms} Interval(Collection)>>atRandom |14.4% {2000ms} Interval(SequenceableCollection)>>atRandom: | |7.0% {972ms} Random>>nextInt: | | |4.4% {611ms} Random>>next | | | 3.4% {472ms} Random>>nextValue | |5.2% {722ms} Interval>>at: | | 4.0% {556ms} primitives |4.7% {653ms} Semaphore>>critical: | 3.0% {417ms} BlockContext>>ensure: 4.2% {583ms} SmallInteger(Number)>>to: 2.9% {403ms} Interval class>>from:to:by: Leaves 72.5% {10070ms} Delay>>wait 4.0% {556ms} Interval>>at: 2.3% {319ms} Interval>>size Attachments: MessageTally.st 21.6 KB _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixProposed Labels: Milestone-1.4 Type-Bug Comment #1 on issue 4689 by [hidden email]: MessageTally defect http://code.google.com/p/pharo/issues/detail?id=4689 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixReviewNeeded Comment #2 on issue 4689 by [hidden email]: MessageTally defect http://code.google.com/p/pharo/issues/detail?id=4689 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #3 on issue 4689 by [hidden email]: MessageTally defect http://code.google.com/p/pharo/issues/detail?id=4689 Thanks andrea. BTW did you sign the license agreement? _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #4 on issue 4689 by [hidden email]: MessageTally defect http://code.google.com/p/pharo/issues/detail?id=4689 Andrea from where did you take this version because it contains old code like asOop that has been removed from pharo since ages. I'm a bit relunctant to merge it blindly. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #5 on issue 4689 by [hidden email]: MessageTally defect http://code.google.com/p/pharo/issues/detail?id=4689 - I just took a MessageTally I had in a Squeak image! I know it is old, you don't need to take it, it's just what I put into my pharo images. Let me look it up... Ok, most probably it comes from System-sd.101 (http://source.squeakfoundation.org/39a). Maybe you can take the newest squeaky MessageTally and port it to pharo. Or anyone can find out why the pharo MessageTally is corrupt :-) - I haven't signed the license agreement yet -> to do _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #6 on issue 4689 by marianopeck: MessageTally defect http://code.google.com/p/pharo/issues/detail?id=4689 Hi Andreas. Indeed, what you should do is identify WHAT/WHERE is broken in MessageTally of Pharo and just take the fix from Squeak. Taking the whole MessageTally class from Squeak is not good because we may have been doing a lot of changes in MessageTally since the last 3 years and they will lost otherwise. thanks _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Accepted Comment #7 on issue 4689 by [hidden email]: MessageTally defect http://code.google.com/p/pharo/issues/detail?id=4689 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #8 on issue 4689 by [hidden email]: MessageTally defect http://code.google.com/p/pharo/issues/detail?id=4689 I am sorry but I can not work on this issue now, please ignore the attached file and regard this issue as an open bug report. thanks _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Labels: -Milestone-1.4 Milestone-1.5 Comment #9 on issue 4689 by [hidden email]: MessageTally defect http://code.google.com/p/pharo/issues/detail?id=4689 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Free forum by Nabble | Edit this page |