Issue 4699 in pharo: Selected list item color in Vistary, W2K, Watery and Watery 2

Status: Accepted
Owner: ----
Labels: Milestone-1.3 Milestone-1.4

New issue 4699 by renggli: Selected list item color in Vistary, W2K, Watery  
and Watery 2
http://code.google.com/p/pharo/issues/detail?id=4699

The text color of selected list items in the Vistary, W2K, Watery and  
Watery 2 themes is white, which turns the selected item unreadable.  
Changing the setting #textSelectionColor: to black fixes this problem, but  
introduces other problems (Issue 4615) in text-areas.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #1 on issue 4699 by renggli: Selected list item color in Vistary,  
W2K, Watery and Watery 2
http://code.google.com/p/pharo/issues/detail?id=4699

Attached the fix to the described problem. It simply reverts the change of  
LazyListMorph>>#colorForRow to the implementation of Pharo 1.2.

Attachments:
        LazyListMorph-colorForRow.st  250 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4699 by [hidden email]: Selected list item color in  
Vistary, W2K, Watery and Watery 2
http://code.google.com/p/pharo/issues/detail?id=4699

I would not do that because it means no way to have more contrasting colors  
for list selection. What about a listSelectionTextColor setting ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4699 by [hidden email]: Selected list item color  
in Vistary, W2K, Watery and Watery 2
http://code.google.com/p/pharo/issues/detail?id=4699

Should not be theme dependent?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4699 by renggli: Selected list item color in Vistary,  
W2K, Watery and Watery 2
http://code.google.com/p/pharo/issues/detail?id=4699

The point is that the contrast of the selected text entry in the themes  
Vistary, W2K, Watery and Watery 2 is so low that it is not readable (white  
text on light blue background).

Indeed a new setting #listSelectionTextColor would help, but then I wonder  
if these settings really make sense (also they are always lost as soon as  
you change the theme)? As Stef says, the theme should be just usable by  
default.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Started

Comment #5 on issue 4699 by [hidden email]: Selected list item color  
in Vistary, W2K, Watery and Watery 2
http://code.google.com/p/pharo/issues/detail?id=4699

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4699 by [hidden email]: Selected list item color  
in Vistary, W2K, Watery and Watery 2
http://code.google.com/p/pharo/issues/detail?id=4699

so what is the status on this one?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4699 by [hidden email]: Selected list item color in  
Vistary, W2K, Watery and Watery 2
http://code.google.com/p/pharo/issues/detail?id=4699

I will provide a fix
Alain


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #8 on issue 4699 by [hidden email]: Selected list item color in  
Vistary, W2K, Watery and Watery 2
http://code.google.com/p/pharo/issues/detail?id=4699

The problem is that #contrastingColor is used for selectionTextColor.

for 1.3:
attached selectionTextColor.2.cs

for 1.4:
SLICE-Issue-4699--Selected-list-item-color-in-Vistary-W2K-Watery-and-Watery-2-AlainPlantec.1



Attachments:
        selectionTextColor.2.cs  1.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 4699 by [hidden email]: Selected list item color  
in Vistary, W2K, Watery and Watery 2
http://code.google.com/p/pharo/issues/detail?id=4699

thanks alain!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4699 by [hidden email]: Selected list item  
color in Vistary, W2K, Watery and Watery 2
http://code.google.com/p/pharo/issues/detail?id=4699

in 14129

TODO: 1.3


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #11 on issue 4699 by [hidden email]: Selected list item  
color in Vistary, W2K, Watery and Watery 2
http://code.google.com/p/pharo/issues/detail?id=4699

in 13305


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 4699 by renggli: Selected list item color in Vistary,  
W2K, Watery and Watery 2
http://code.google.com/p/pharo/issues/detail?id=4699

Thank you!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker