Issue 4714 in pharo: Methods to change haltOnce globally do not belong in Object

Status: New
Owner: ----

New issue 4714 by [hidden email]: Methods to change haltOnce  
globally do not belong in Object
http://code.google.com/p/pharo/issues/detail?id=4714

Pharo1.4a update: #14109

setHaltOnce
toggleHaltOnce
clearHaltOnce
haltOnceEnabled

Maybe they should be in SmalltalkImage?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Accepted

Comment #1 on issue 4714 by [hidden email]: Methods to change  
haltOnce globally do not belong in Object
http://code.google.com/p/pharo/issues/detail?id=4714

Indeed related to

Thanks to Stephan Eggermont who paired with me all morning on this.

Here are the results of the first pass in inbox
(SLICE-Issue-2394-Halt-SeanDeNigris.1):

Object
* 16 methods deprecated
* 5 halt methods that now forward to Halt

Globals - can remove #HaltOnce and #HaltCount (I don't know how)

Halt class
* methods (all heavily refactored from the original Object implementation)
  - 5 for halting API
  - 3 to enable/disable haltOnce
  - 6 private helpers
* 2 class instance variables (for haltOnce/onCount)

World menu - updated to use Halt API

Tests
* 6 new assertions in 2 test methods
* 4 test helpers for halt behavior
* changed other halt tests to use the helpers

Questions remaining:
* countOn: (which I left it in for the time being)
  - safety & scope (see earlier in thread)
  - method name


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4714 by [hidden email]: Methods to change  
haltOnce globally do not belong in Object
http://code.google.com/p/pharo/issues/detail?id=4714

2394



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: closed

Comment #3 on issue 4714 by [hidden email]: Methods to change  
haltOnce globally do not belong in Object
http://code.google.com/p/pharo/issues/detail?id=4714

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker