Issue 4771 in pharo: Three tests for Finder are failing

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Milestone-1.4

New issue 4771 by [hidden email]: Three tests for Finder are failing
http://code.google.com/p/pharo/issues/detail?id=4771

>>> Finder.Tests.MethodFinderTest.testIsOdd 0.072 1
>>> Finder.Tests.MethodFinderTest.testIsRadix 0.072 1
>>> Finder.Tests.MethodFinderTest.testMethodFor


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4771 by [hidden email]: Three tests for Finder  
are failing
http://code.google.com/p/pharo/issues/detail?id=4771

Reason: uses the removed Object>>#closeTo: method.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4771 by [hidden email]: Three tests for Finder  
are failing
http://code.google.com/p/pharo/issues/detail?id=4771

(this is what I always try to explain to people: no method can be strange  
and useless enough to not be used in a place where you would never expect  
it... the current implementation violates the "law of the least surprise"  
constantly).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4771 by [hidden email]: Three tests for Finder  
are failing
http://code.google.com/p/pharo/issues/detail?id=4771

And looking at the code... I already once just plainly deleted the  
MethodFinder... sadly people objected.
(the code is *awful*)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-FailingTest

Comment #4 on issue 4771 by [hidden email]: Three tests for Finder  
are failing
http://code.google.com/p/pharo/issues/detail?id=4771

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #5 on issue 4771 by [hidden email]: Three tests for Finder  
are failing
http://code.google.com/p/pharo/issues/detail?id=4771

I am sure nobody will dare to touch the code of MethodFinder.

So we should add again  Object>>#closeTo:, but as an extension of the  
Finder package and a comment
so people don't use it.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #6 on issue 4771 by [hidden email]: Three tests for Finder  
are failing
http://code.google.com/p/pharo/issues/detail?id=4771

Fix attached

Attachments:
        FixFinder.1.cs  6.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 4771 by [hidden email]: Three tests for Finder  
are failing
http://code.google.com/p/pharo/issues/detail?id=4771

in 14157


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker