Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
27 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Status: New
Owner: ----

New issue 4773 by [hidden email]: rename includesAnyOf: and  
includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773

Drop the trailing "Of" from the selector names.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo

Comment #1 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773

refactored in

SLICE-Issue-4773-rename-includesAnyOf-and-includesAllOf-CamilloBruni.1




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo

Comment #2 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773

should be loaded together with
SLICE-Issue-4780-Unify-union-difference-intersection-on-Collections-CamilloBruni.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Updates:
        Status: FixProposed
        Labels: Milestone-1.4

Comment #3 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Updates:
        Labels: Type-Cleanup

Comment #4 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Updates:
        Status: MonkeyIsChecking

Comment #5 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773#c5

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Updates:
        Status: ReviewNeeded

Comment #6 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773#c6

This Issue has been marked for review by Ulysse the Monkey:

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-4773-rename-includesAnyOf-and-includesAllOf-CamilloBruni.1 from  
http://ss3.gemstone.com/ss/PharoInbox:
        MessageNotUnderstood: receiver of "precedence" is nil
  1: UndefinedObject(Object)>>doesNotUnderstand: #precedence
  2:
DecompilerConstructorForClosures(DecompilerConstructor)>>codeMessage:selector:arguments:
  3: Decompiler>>send:super:numArgs:
  4: Decompiler(InstructionStream)>>interpretNextInstructionFor:
  5: Decompiler>>interpretNextInstructionFor:
  6: Decompiler>>statementsTo:
  7: Decompiler>>blockTo:
  8: Decompiler>>jump:if:
  9: Decompiler(InstructionStream)>>interpretNextInstructionFor:
10: Decompiler>>interpretNextInstructionFor:
        ...Test Results:
-------------
Errors:
        SystemChangeErrorHandlingTest>>#testHaltOperation
        SystemChangeErrorHandling>>#testHaltOperation
Failures:
        HostWindowTests>>#testOne
        MirrorPrimitiveTests>>#testMirrorSize
        MethodContextTest>>#testClosureRestart
        ObjectFinalizerTests>>#testFinalizationOfMultipleResources
        BecomeTest>>#testBecomeIdentityHash
        ClassHierarchyTest>>#testSubclasses
        ReleaseTest>>#testUndeclared
        FileStreamTest>>#testPositionPastEndIsAtEnd
        ReleaseTest>>#testObsoleteClasses
        AllocationTest>>#testOneGigAllocation

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-4773-rename-includesAnyOf-and-includesAllOf-CamilloBruni.1 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-1.4-14160-a on Croquet Closure Stack VM  
[StackInterpreter VMMaker-oscog-EstebanLorenzano.109] 21.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Updates:
        Status: MonkeyIsChecking

Comment #7 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773#c7

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo

Comment #8 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773#c8

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo

Comment #9 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773

@meta-comment: The monkey hangs here because the tests are not yet now  
handles warnings like deprecations (see Issue 4855)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo

Comment #10 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773#c10

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Updates:
        Status: FixToInclude

Comment #11 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Updates:
        Status: ReviewNeeded

Comment #12 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773

There is a Nautlis package in the Slice.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Updates:
        Status: MonkeyIsChecking

Comment #13 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773#c13

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Updates:
        Status: FixToInclude

Comment #14 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773#c14

This Issue has been checked by Ulysse the Monkey
       
6203 tests passed in 00:01:08s:
===============================
        CollectionsTests-Arrayed (562)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (590)
        CollectionsTests-Support (12)
        CollectionsTests-Text (40)
        CollectionsTests-Unordered (1977)
        CollectionsTests-Weak (751)
        CompilerTests (30)
        KernelTests-Chronology (574)
        KernelTests-Classes (59)
        KernelTests-Exception (2)
        KernelTests-Methods (177)
        KernelTests-Numbers (232)
        KernelTests-Objects (85)
        KernelTests-Pragmas (3)
        KernelTests-Processes (22)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (77)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-4773-rename-includesAnyOf-and-includesAllOf-CamilloBruni.3 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-1.4-14179-a on Croquet Closure Stack VM  
[StackInterpreter VMMaker-oscog-EstebanLorenzano.109] 21.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Updates:
        Status: MonkeyIsChecking

Comment #15 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773#c15

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Updates:
        Status: ReviewNeeded

Comment #16 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773#c16

This Issue has been marked for review by Ulysse the Monkey:

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-4773-rename-includesAnyOf-and-includesAllOf-CamilloBruni.6 from  
http://ss3.gemstone.com/ss/PharoInbox:
        Warning: You are about to load new versions of the following packages that  
have unsaved changes in the image.  If you continue, you will lose these  
changes.

   Kernel
   KernelTests
   Tests
   Kernel
   KernelTests
   Tests
  1: MCVersionLoader(Object)>>notify:
  2: MCVersionLoader>>warnAboutLosingChangesTo:
  3: MCVersionLoader>>checkForModifications
  4: MCVersionLoader>>loadWithNameLike:
  5: MCVersionLoader>>load
  6: GoferLoad>>execute
  7: Gofer>>execute:do:
  8: Gofer>>execute:
  9: Gofer>>load
10: GoferResolvedReference>>load
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-4773-rename-includesAnyOf-and-includesAllOf-CamilloBruni.6 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-1.4-14183-a on Croquet Closure Stack VM  
[StackInterpreter VMMaker-oscog-EstebanLorenzano.109] 21.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Updates:
        Status: Started

Comment #17 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773

When I merge the SLICE, the methods without the off are not added to  
collection but just TimeSpan.

Seems the SLICE misses some of the changes.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Updates:
        Status: Workneeded

Comment #18 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4773 in pharo: rename includesAnyOf: and includesAllOf:

pharo
Updates:
        Status: FixReviewNeeded

Comment #19 on issue 4773 by [hidden email]: rename includesAnyOf:  
and includesAllOf:
http://code.google.com/p/pharo/issues/detail?id=4773

- updated the slice to include the missing methods
- removed unintentionally added code

see:
SLICE-Issue-4773-rename-includesAnyOf-and-includesAllOf-CamilloBruni.8


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
12