Issue 4791 in pharo: Add a class to have a better holding of IconicList items

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
30 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Status: FixProposed
Owner: ----
Labels: Milestone-1.4 Type-Feature

New issue 4791 by [hidden email]: Add a class to have a better  
holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791

Add a class to have a better holding of IconicList items


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo

Comment #1 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791

My bad :)

Attachments:
        FixIconicLists.1.cs  8.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: Started

Comment #2 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791

I can not file in the change set. Now I can redo 15 minutes of work.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: FixProposed

Comment #3 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791

Sorry :s

Here the new version

Attachments:
        FixIconicLists.1.cs  1.0 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: Started

Comment #4 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791

No, I can  not file in the change set.

*PLEASE* take a fresh, latest, clean 1.4 image and test your changeset. And  
by test mean, really, really do
it. Even if you think there is no possibility that it is not working.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo

Comment #5 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791

So why the change sorter produce unreadable files ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: FixProposed

Comment #6 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791

Redo and checked

Sorry for the waste of time :s

Attachments:
        FixIconicLists.1.cs  1.2 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: Closed

Comment #7 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791

in 14141


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: Started

Comment #8 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791

update 14141 was retracted due to problems


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: ReviewNeeded

Comment #9 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: FixProposed

Comment #10 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791

the problems comes from the other change :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: Integrated

Comment #11 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791

in 14159


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: MonkeyIsChecking

Comment #12 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791#c12

The Monkey is currently checking this issue. Please don't change this issue.
       
        Freeze, I said "Freeze" #@$%!!!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: ReviewNeeded

Comment #13 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791#c13

This Issue has been marked for review by Ulysse the Monkey:

Monkey went bananas:
--------------------
  1: ByteArray(Object)>>doesNotUnderstand: #contractTo:
  2: UnixFileDirectory(FileDirectory)>>checkName:fixErrors:
  3: UnixFileDirectory>>checkName:fixErrors:
  4: [:filePath :localName |
        correctedLocalName := localName isEmpty
                                        ifTrue: [localName]
                                        ifFalse: [self checkName: localName fixErrors: true].
                prefix := self fullPathFor: filePath] in  
UnixFileDirectory(FileDirectory)>>fullNameFor:
  5: UnixFileDirectory class(FileDirectory class)>>splitName:to:
  6: UnixFileDirectory(FileDirectory)>>fullNameFor:
  7: FileStream class>>fullName:
  8: FileStream class>>readOnlyFileNamed:
  9: FileStream class>>fileIn:
10: [:attachment | FileStream fileIn: attachment contents] in [self issue  
changeSets
                        do: [:attachment | FileStream fileIn: attachment contents].
                extraTests := self dirtyPackagesTests] in ChangeLoader>>loadCS
        ...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: MonkeyIsChecking

Comment #14 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791#c14

The Monkey is currently checking this issue. Please don't change this issue.
       
        Freeze, I said "Freeze" #@$%!!!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: ReviewNeeded

Comment #15 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791#c15

This Issue has been marked for review by Ulysse the Monkey:

Monkey went bananas:
--------------------
        Error while loading FixIconicLists.1.cs:
  1: ByteArray(Object)>>doesNotUnderstand: #contractTo:
  2: UnixFileDirectory(FileDirectory)>>checkName:fixErrors:
  3: UnixFileDirectory>>checkName:fixErrors:
  4: [:filePath :localName |
        correctedLocalName := localName isEmpty
                                        ifTrue: [localName]
                                        ifFalse: [self checkName: localName fixErrors: true].
                prefix := self fullPathFor: filePath] in  
UnixFileDirectory(FileDirectory)>>fullNameFor:
  5: UnixFileDirectory class(FileDirectory class)>>splitName:to:
  6: UnixFileDirectory(FileDirectory)>>fullNameFor:
  7: FileStream class>>fullName:
  8: FileStream class>>readOnlyFileNamed:
  9: FileStream class>>fileIn:
10: [FileStream fileIn: attachment contents] in [:attachment | [FileStream  
fileIn: attachment contents]
                        on: Exception
                        do: [:e | self addError: e forFile: attachment filename]] in [self issue  
changeSets
                        do: [:attachment | [FileStream fileIn: attachment contents]
                                        on: Exception
                                        do: [:e | self addError: e forFile: attachment filename]].
                extraTests := self dirtyPackagesTests] in ChangeLoader>>loadCS
        ...

--------------------
  1: EncoderForV3PlusClosures(Encoder)>>undeclared:
  2: Parser>>correctVariable:interval:
  3: [self
                        correctVariable: varName
                        interval: (varStart to: varEnd)] in Parser>>variable
  4: [(self
                                lookupInPools: name
                                ifFound: [:assoc | varNode := self global: assoc name: name])
                        ifTrue: [varNode]
                        ifFalse: [^ action value]] in  
EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  5: Dictionary>>at:ifAbsent:
  6: EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  7: Parser>>variable
  8: Parser>>primaryExpression
  9: Parser>>messagePart:repeat:
10: Parser>>expression
        ...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: MonkeyIsChecking

Comment #16 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791#c16

The Monkey is currently checking this issue. Please don't change this issue.
       
        Freeze, I said "Freeze" #@$%!!!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: ReviewNeeded

Comment #17 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791#c17

This Issue has been marked for review by Ulysse the Monkey:

Monkey went bananas:
--------------------
        UndeclaredVariableWarning
  1: EncoderForV3PlusClosures(Encoder)>>undeclared:
  2: Parser>>correctVariable:interval:
  3: [self
                        correctVariable: varName
                        interval: (varStart to: varEnd)] in Parser>>variable
  4: [(self
                                lookupInPools: name
                                ifFound: [:assoc | varNode := self global: assoc name: name])
                        ifTrue: [varNode]
                        ifFalse: [^ action value]] in  
EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  5: Dictionary>>at:ifAbsent:
  6: EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  7: Parser>>variable
  8: Parser>>primaryExpression
  9: Parser>>messagePart:repeat:
10: Parser>>expression
        ...

--------------------
Error while loading "FixIconicLists.1.cs":
        MessageNotUnderstood: ByteArray>>contractTo:
  1: ByteArray(Object)>>doesNotUnderstand: #contractTo:
  2: UnixFileDirectory(FileDirectory)>>checkName:fixErrors:
  3: UnixFileDirectory>>checkName:fixErrors:
  4: [:filePath :localName |
        correctedLocalName := localName isEmpty
                                        ifTrue: [localName]
                                        ifFalse: [self checkName: localName fixErrors: true].
                prefix := self fullPathFor: filePath] in  
UnixFileDirectory(FileDirectory)>>fullNameFor:
  5: UnixFileDirectory class(FileDirectory class)>>splitName:to:
  6: UnixFileDirectory(FileDirectory)>>fullNameFor:
  7: FileStream class>>fullName:
  8: FileStream class>>readOnlyFileNamed:
  9: FileStream class>>fileIn:
10: [FileStream fileIn: attachment contents] in [:attachment | [FileStream  
fileIn: attachment contents]
                        on: Exception
                        do: [:e | self addError: e forFile: attachment filename]] in [self issue  
changeSets
                        do: [:attachment | [FileStream fileIn: attachment contents]
                                        on: Exception
                                        do: [:e | self addError: e forFile: attachment filename]].
                extraTests := self dirtyPackagesTests] in ChangeLoader>>loadCS
        ...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: MonkeyIsChecking

Comment #18 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791#c18

The Monkey is currently checking this issue. Please don't change this issue.
       
        Freeze, I said "Freeze" #@$%!!!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4791 in pharo: Add a class to have a better holding of IconicList items

pharo
Updates:
        Status: ReviewNeeded

Comment #19 on issue 4791 by [hidden email]: Add a class to have a  
better holding of IconicList items
http://code.google.com/p/pharo/issues/detail?id=4791#c19

This Issue has been marked for review by Ulysse the Monkey:

Monkey went bananas:
--------------------
Error while loading "FixIconicLists.1.cs" from Comment #6:
        MessageNotUnderstood: ByteArray>>contractTo:
  1: ByteArray(Object)>>doesNotUnderstand: #contractTo:
  2: UnixFileDirectory(FileDirectory)>>checkName:fixErrors:
  3: UnixFileDirectory>>checkName:fixErrors:
  4: [:filePath :localName |
        correctedLocalName := localName isEmpty
                                        ifTrue: [localName]
                                        ifFalse: [self checkName: localName fixErrors: true].
                prefix := self fullPathFor: filePath] in  
UnixFileDirectory(FileDirectory)>>fullNameFor:
  5: UnixFileDirectory class(FileDirectory class)>>splitName:to:
  6: UnixFileDirectory(FileDirectory)>>fullNameFor:
  7: FileStream class>>fullName:
  8: FileStream class>>readOnlyFileNamed:
  9: FileStream class>>fileIn:
10: [FileStream fileIn: attachment contents] in [:attachment | [FileStream  
fileIn: attachment contents]
                        on: Exception
                        do: [:e | self addError: e forFile: '"' , attachment filename , '" from  
Comment #' , attachment comment id asString]] in [self issue changeSets
                        do: [:attachment | [FileStream fileIn: attachment contents]
                                        on: Exception
                                        do: [:e | self addError: e forFile: '"' , attachment filename , '"  
from Comment #' , attachment comment id asString]].
                extraTests := self dirtyPackagesTests] in ChangeLoader>>loadCS
        ...

--------------------
        UndeclaredVariableWarning
  1: EncoderForV3PlusClosures(Encoder)>>undeclared:
  2: Parser>>correctVariable:interval:
  3: [self
                        correctVariable: varName
                        interval: (varStart to: varEnd)] in Parser>>variable
  4: [(self
                                lookupInPools: name
                                ifFound: [:assoc | varNode := self global: assoc name: name])
                        ifTrue: [varNode]
                        ifFalse: [^ action value]] in  
EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  5: Dictionary>>at:ifAbsent:
  6: EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  7: Parser>>variable
  8: Parser>>primaryExpression
  9: Parser>>messagePart:repeat:
10: Parser>>expression
        ...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
12