Issue 4795 in pharo: rename is not working in FS

Status: Accepted
Owner: [hidden email]

New issue 4795 by [hidden email]: rename is not working in FS
http://code.google.com/p/pharo/issues/detail?id=4795

If you fill an issue for the first time, please read "How to report bugs"
at http://www.pharo-project.org/community/issue-tracking

Pharo image: <core, dev or web>
Pharo core version: <copy from World/System/About>
Virtual machine used: <ex: pharo-vm-0.15.2f-linux>
Class browser used if applicable: <ex: O2PackageBrowserAdaptor. If you
don't
know, print "SystemBrowser default">

Steps to reproduce:
1.
2.
3.


Paste or attach stack trace if applicable (look at the file PharoDebug.log
located in the same directory as your image):



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4795 by [hidden email]: rename is not working in  
FS
http://code.google.com/p/pharo/issues/detail?id=4795


rename: sourcePath ifAbsent: aBlock as: destPath ifPresent: pBlock
        "Rename the file referenced as sourcePath to the destination referred as  
destPath.
        Perform associate actions in case of problems."
       
        | source destination |
        source := self resolve: sourcePath.
        destination := self resolve: destPath.
        self basicRename: source ifAbsent: aBlock as: destination ifPresent: pBlock


So basicRename: ifAbsentL ifPresent: does not exist.

Even though FSFilePluginPrims implements name: oldFileFullName to:  
newFileFullName

rename: oldFileFullName to: newFileFullName
        "Rename the file of the given name to the new name. Fail if there is no  
file of the old name
        or if there is an existing file with the new name."

        <primitive: 'primitiveFileRename' module: 'FilePlugin'>
        ^nil





_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4795 by [hidden email]: rename is not working in  
FS
http://code.google.com/p/pharo/issues/detail?id=4795


| working  |
working := FSFilesystem disk workingDirectory.
working / 'foo.txt' writeStreamDo: [ :stream | stream nextPutAll: 'Hello  
World' ].
working / 'foo.txt' renameAs: working /  'zork.txt'


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Feature

Comment #3 on issue 4795 by [hidden email]: rename is not working in  
FS
http://code.google.com/p/pharo/issues/detail?id=4795

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4795 by [hidden email]: rename is not working in  
FS
http://code.google.com/p/pharo/issues/detail?id=4795

I uploaded code to FS on SqS that has rename working (tested by hand for  
disk filesystems) and adds move functionality. See  
http://forum.world.st/Moving-a-file-td3983916.html


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #5 on issue 4795 by [hidden email]: rename is not working in  
FS
http://code.google.com/p/pharo/issues/detail?id=4795

I merged in this version and updated the Configuration on Squeaksource.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4795 by [hidden email]: rename is not working in  
FS
http://code.google.com/p/pharo/issues/detail?id=4795

Sync also with FS configuration..


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #7 on issue 4795 by [hidden email]: rename is not working in  
FS
http://code.google.com/p/pharo/issues/detail?id=4795

in 14310


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker