Issue 4813 in pharo: MethodWrapper

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.4

New issue 4813 by [hidden email]: MethodWrapper
http://code.google.com/p/pharo/issues/detail?id=4813

Hi All,

     I've completed porting MethodWrappers to Squeak 4.2.  You'll need to  
update your image to at least Compiler-eem.215 & Kernel-eem.623.  You can  
find MethodWrappers4.2-eem.17 at  
http://www.squeaksource.com/MethodWrappers.  Enjoy.

P.S.  Anyone in VW land interested in updating the codee?  The class  
comments in VW are obsolete (valueNowOrOnUnwindDo: is mentioned instead of  
ensure: etc).  If you do update the code you might want to add the tweak I  
did to MwBlockMethodWrapper>valueWithReceiver:arguments: to make both  
before and after blocks optional. i.e.

MwBlockMethodWrapper methods for evaluating
valueWithReceiver: anObject arguments: anArrayOfObjects
        "Optionally evaluate beforeBlock before evaluating clientMethod if  
beforeBlock is non-nil.
         Optionally evaluate afterBlock afterwards if afterBlock is non-nil."
        self wasActive: true.
        self beforeBlock ifNotNil:
                [:beforeBlock| beforeBlock value: anObject value: anArrayOfObjects].
        ^self afterBlock
                ifNil: [self clientMethod valueWithReceiver: anObject arguments:  
anArrayOfObjects]
                ifNotNil:
                        [:afterBlock|
                        [self clientMethod valueWithReceiver: anObject arguments:  
anArrayOfObjects]
                                ensure: [afterBlock value: anObject value: anArrayOfObjects]]



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4813 by [hidden email]: MethodWrapper
http://code.google.com/p/pharo/issues/detail?id=4813


I was hoping someone with focus on Pharo would integrate the necessary  
compiler and kernel changes into Pharo.  The Squeak trunk packages are  
Compiler-eem.214 & Compiler-eem.215, and Kernel-619 to Kernel-eem.623.  
I've attached the diffs.  Notionally file in Compiler-213-214.st &  
Kernel-618-619.st, then file-in Compiler-214-215.st & Kernel-619-623.st.  
These are generally useful, a) restoring the ability to create subclasses  
of CompiledMethod, and b) fixing various subtle copying-related  
state-sharing bugs with AdditionalMethodState (the objects that add  
additional state to compiled methods, pragmas, properties and "extra inst  
vars").



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4813 by [hidden email]: MethodWrapper
http://code.google.com/p/pharo/issues/detail?id=4813

Eliot's attachements

Attachments:
        Compiler-213-214.st  3.2 KB
        Compiler-214-215.st  1.3 KB
        Kernel-618-619.st  1.2 KB
        Kernel-619-623.st  7.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ReviewNeeded

Comment #3 on issue 4813 by [hidden email]: MethodWrapper
http://code.google.com/p/pharo/issues/detail?id=4813

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Feature

Comment #4 on issue 4813 by [hidden email]: MethodWrapper
http://code.google.com/p/pharo/issues/detail?id=4813

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #5 on issue 4813 by [hidden email]: MethodWrapper
http://code.google.com/p/pharo/issues/detail?id=4813

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #6 on issue 4813 by [hidden email]: MethodWrapper
http://code.google.com/p/pharo/issues/detail?id=4813

We compared the changes with what is now in the image. Looks good.

- Compiler recompileAll works
- Compiler tests are green
- AdditionalMethodStateTest and CompiledMethod is green

fix for testNew of Compiledmethod is attached

Attachments:
        FixCompiledMethodTest.1.cs  142 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 4813 by [hidden email]: MethodWrapper
http://code.google.com/p/pharo/issues/detail?id=4813

in 14320 and 14321


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker