Issue 4818 in pharo: Fix for AbstractTool

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4818 in pharo: Fix for AbstractTool

pharo
Status: FixProposed
Owner: [hidden email]
Labels: Milestone-1.4 Type-Feature

New issue 4818 by [hidden email]: Fix for AbstractTool
http://code.google.com/p/pharo/issues/detail?id=4818

This entry depends on Issue 4817

Fix the getter/setter creation and the entry point creation to make them  
use TickDialogWindow

Attachments:
        AbstractTool.BenjaminVanRyseghem.1.cs  3.0 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4818 in pharo: Fix for AbstractTool

pharo

Comment #1 on issue 4818 by [hidden email]: Fix for AbstractTool
http://code.google.com/p/pharo/issues/detail?id=4818

Mini roll back, in addition of the previous cs

Attachments:
        NewAbstractToolFix.1.cs  1.0 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4818 in pharo: Fix for AbstractTool

pharo

Comment #2 on issue 4818 by [hidden email]: Fix for AbstractTool
http://code.google.com/p/pharo/issues/detail?id=4818

ben I integrated you changes. Now one day we will have to sit and think  
about that is the purpose of abstractTool because may be there are methods  
that should only be there for Browsers.
So we may end up to have to create
AbstractTool
     AbstractBrowser

so that the core stay focused on behavior for tools.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4818 in pharo: Fix for AbstractTool

pharo

Comment #3 on issue 4818 by [hidden email]: Fix for AbstractTool
http://code.google.com/p/pharo/issues/detail?id=4818

So should I only integrate the second one?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4818 in pharo: Fix for AbstractTool

pharo
Updates:
        Status: Closed

Comment #4 on issue 4818 by [hidden email]: Fix for AbstractTool
http://code.google.com/p/pharo/issues/detail?id=4818

I loaded the first and the second.
So we will see :)

Integrated in 14151


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4818 in pharo: Fix for AbstractTool

pharo

Comment #5 on issue 4818 by [hidden email]: Fix for AbstractTool
http://code.google.com/p/pharo/issues/detail?id=4818

It was the good thing to do :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker