Status: New
Owner: ----
Labels: Milestone-1.3 Type-Bug
New issue 4840 by
[hidden email]: Schedule>>between:and:do can iterate
over the wrong dates.
http://code.google.com/p/pharo/issues/detail?id=4840If the start date sent to #between:and:do is a different day of the week
than the start date of the schedule, #between:and:do outputs different
dates than probably expected.
1. run this failing test:
ScheduleTest>>testDaysOfWeekAreConsistent
| originalDayOfWeekSet modifiedDayOfWeekSet start end |
originalDayOfWeekSet :=(aSchedule dateAndTimes collect:[:each | each
dayOfWeek]) asSet.
start:=DateAndTime year: 2003 month: 1 day: 5 hour: 20 minute: 30.
end:=DateAndTime year: 2003 month:6 day: 4 hour: 20 minute: 30.
modifiedDayOfWeekSet := OrderedCollection new.
aSchedule between: start and: end do:[:eachStart | modifiedDayOfWeekSet
add: eachStart dayOfWeek ].
self assert: originalDayOfWeekSet equals: modifiedDayOfWeekSet asSet.
2. Change Schedule>>between:and:do to:
between: aStart and: anEnd do: aBlock
"from Cuis 99"
| element end i startDate |
end := self end min: anEnd.
element := self start.
"Performance optimization. Avoid going through unnecesary days if easy."
startDate := aStart asDate.
(startDate > element asDate and: [ self everyDayAtSameTimes ]) ifTrue: [
element := DateAndTime date: startDate time: element asTime ].
i := 1.
[ element < aStart ] whileTrue: [
element := element + (schedule at: i).
i := i + 1.
i > schedule size ifTrue: [i := 1]].
[ element <= end ] whileTrue: [
aBlock value: element.
element := element + (schedule at: i).
i := i + 1.
i > schedule size ifTrue: [i := 1]].
The proposed change prevents the iteraring temp var i from being reset to 1
after the [ element < aStart ] whileTrue: [...] block.
3. Run the test above and it passes. As do all the other schedule tests.
_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Locked
