Issue 4843 in pharo: Alternative Condense changes: prune unvisible

Status: Accepted
Owner: [hidden email]

New issue 4843 by [hidden email]: Alternative Condense changes:  
prune unvisible
http://code.google.com/p/pharo/issues/detail?id=4843

 From Eliot:


yes please send it.
How do you determine ancestry?

Here's the phrase:

                                                        ChangeSet directAncestryOfVersions: (ChangeSet
                                                                                                                        scanVersionsOf: method
                                                                                                                        class: self
                                                                                                                        meta: self isMeta
                                                                                                                        category: category
                                                                                                                        selector: selector)

the scanVersionsOf: is standard, and then I added directAncestryOfVersions:  
to filter appropriately.


Find attached.  You'll need to understand it, test it and integrate it, but  
it worked fine for me.  I haven't had time or occasion to push it to Squeak  
trunk.  But if people like it I'll think about doing so.  I agree with  
Henrik that this is a useful default.  I love method versions, and noise is  
noise, so this is having one's cake and eating it too :)


Attachments:
        condenseChanges.st  9.3 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ReviewNeeded
        Cc: [hidden email]

Comment #1 on issue 4843 by [hidden email]: Alternative Condense changes:  
prune unvisible
http://code.google.com/p/pharo/issues/detail?id=4843

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Feature Milestone-1.4

Comment #2 on issue 4843 by [hidden email]: Alternative Condense  
changes: prune unvisible
http://code.google.com/p/pharo/issues/detail?id=4843

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #3 on issue 4843 by [hidden email]: Alternative Condense  
changes: prune unvisible
http://code.google.com/p/pharo/issues/detail?id=4843

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #4 on issue 4843 by [hidden email]: Alternative Condense  
changes: prune unvisible
http://code.google.com/p/pharo/issues/detail?id=4843

After reading the code. It seems ok, that can be problematic to integrate  
(one method seems be used in the FileIn process). But one by one the method  
is correctly integrated, and the test on class success.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4843 by [hidden email]: Alternative Condense  
changes: prune unvisible
http://code.google.com/p/pharo/issues/detail?id=4843

I think we should test it really well... doing a condense changes and check  
integrity of the result.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #6 on issue 4843 by [hidden email]: Alternative Condense  
changes: prune unvisible
http://code.google.com/p/pharo/issues/detail?id=4843

-> Chageset contaims CObject change

-> When I do "Smalltalk condenseChanges", I get a DNU

SourceFiles readOnlyCopyAt:


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4843 by [hidden email]: Alternative Condense  
changes: prune unvisible
http://code.google.com/p/pharo/issues/detail?id=4843

fix, checked seems ok.

Attachments:
        condenseChanges.st  7.4 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4843 by [hidden email]: Alternative Condense  
changes: prune unvisible
http://code.google.com/p/pharo/issues/detail?id=4843

#readOnlyCopyAt: is not fixed


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 4843 by [hidden email]: Alternative Condense  
changes: prune unvisible
http://code.google.com/p/pharo/issues/detail?id=4843

Issue 5379 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker