Issue 4854 in pharo: must enforce class name checking and check class name when renaming of copying a class

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.3 Milestone-1.4

New issue 4854 by [hidden email]: must enforce class name checking and  
check class name when renaming of copying a class
http://code.google.com/p/pharo/issues/detail?id=4854

ClassBuilder>>validateClassName: don't check for invalid characters.
as an example, character space is allowed.
when renaming or copying a class, the name must be checked with  
ClassBuilder>>validateClassName:


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #1 on issue 4854 by [hidden email]: must enforce class name  
checking and check class name when renaming of copying a class
http://code.google.com/p/pharo/issues/detail?id=4854

for 1.4
SLICE-Issue-4854-must-enforce-class-name-checking-and-check-class-name-when-renaming-of-copying-a-class-AlainPlantec.1

for 1.3 a cs is attached

Attachments:
        classNameCheck.1.cs  2.7 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Bug

Comment #2 on issue 4854 by [hidden email]: must enforce class name  
checking and check class name when renaming of copying a class
http://code.google.com/p/pharo/issues/detail?id=4854

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #3 on issue 4854 by [hidden email]: must enforce class name  
checking and check class name when renaming of copying a class
http://code.google.com/p/pharo/issues/detail?id=4854#c3

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ReviewNeeded

Comment #4 on issue 4854 by [hidden email]: must enforce class name  
checking and check class name when renaming of copying a class
http://code.google.com/p/pharo/issues/detail?id=4854#c4

This Issue has been marked for review by Ulysse the Monkey:

Test Results:
-------------
Failures:
        AllocationTest>>#testOneGigAllocation
        MethodContextTest>>#testClosureRestart

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-4854-must-enforce-class-name-checking-and-check-class-name-when-renaming-of-copying-a-class-AlainPlantec.1  
from http://ss3.gemstone.com/ss/PharoInbox"classNameCheck.1.cs" from  
Comment #1
Tested using Pharo-1.4-14160-a on Croquet Closure Stack VM  
[StackInterpreter VMMaker-oscog-EstebanLorenzano.109] 21.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #5 on issue 4854 by [hidden email]: must enforce class name  
checking and check class name when renaming of copying a class
http://code.google.com/p/pharo/issues/detail?id=4854#c5

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ReviewNeeded

Comment #6 on issue 4854 by [hidden email]: must enforce class name  
checking and check class name when renaming of copying a class
http://code.google.com/p/pharo/issues/detail?id=4854#c6

This Issue has been marked for review by Ulysse the Monkey:

Test Results:
-------------
Failures:
        MethodContextTest>>#testClosureRestart
        AllocationTest>>#testOneGigAllocation

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-4854-must-enforce-class-name-checking-and-check-class-name-when-renaming-of-copying-a-class-AlainPlantec.1  
from http://ss3.gemstone.com/ss/PharoInbox"classNameCheck.1.cs" from  
Comment #1
Tested using Pharo-1.4-14160-a on Croquet Closure Stack VM  
[StackInterpreter VMMaker-oscog-EstebanLorenzano.109] 21.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #7 on issue 4854 by [hidden email]: must enforce class name  
checking and check class name when renaming of copying a class
http://code.google.com/p/pharo/issues/detail?id=4854#c7

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ReviewNeeded

Comment #8 on issue 4854 by [hidden email]: must enforce class name  
checking and check class name when renaming of copying a class
http://code.google.com/p/pharo/issues/detail?id=4854#c8

This Issue has been marked for review by Ulysse the Monkey:

Test Results:
-------------
Failures:
        MethodContextTest>>#testClosureRestart
        AllocationTest>>#testOneGigAllocation

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-4854-must-enforce-class-name-checking-and-check-class-name-when-renaming-of-copying-a-class-AlainPlantec.1  
from http://ss3.gemstone.com/ss/PharoInbox"classNameCheck.1.cs" from  
Comment #1
Tested using Pharo-1.4-14163-a on Croquet Closure Stack VM  
[StackInterpreter VMMaker-oscog-EstebanLorenzano.109] 21.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #9 on issue 4854 by [hidden email]: must enforce class name  
checking and check class name when renaming of copying a class
http://code.google.com/p/pharo/issues/detail?id=4854

THis is good: the checking happens not deep on the system (as people might  
want to do ugly stuff
when experimenting), but close to the user interaction (Browser). With the  
browser one wants to guide the user carefully to do the right thing.

14164


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #10 on issue 4854 by [hidden email]: must enforce class name  
checking and check class name when renaming of copying a class
http://code.google.com/p/pharo/issues/detail?id=4854

TODO: 1.3


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #11 on issue 4854 by [hidden email]: must enforce class name  
checking and check class name when renaming of copying a class
http://code.google.com/p/pharo/issues/detail?id=4854

in 13311


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker