Issue 4875 in pharo: Polymorph WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly for left and right bottom corner, when corners are rounded.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4875 in pharo: Polymorph WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly for left and right bottom corner, when corners are rounded.

pharo
Status: New
Owner: ----

New issue 4875 by [hidden email]: Polymorph WindowActiveDropShadow  
for ShadowStyle: #diffuse does’t display correctly for left and right  
bottom corner, when corners are rounded.
http://code.google.com/p/pharo/issues/detail?id=4875

Pharo image: Pharo1.3 #13307

Steps to reproduce:
Make an UITheme with
1. rounded window corners on all four sides
2. a windowActiveDropShadow with the shadowStyle: #diffuse

-> the two top corners display nicely (like in UIThemeWatery2) but the  
shadow is not rendered correctly for the two bottom corners. there is empty  
space between the diffuse shadow and the rounded corners.

see attached screenshot.

Attachments:
        dropshadowbug.png  7.1 KB

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4875 in pharo: Polymorph WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly for left and right bottom corner, when corners are rounded.

pharo
Updates:
        Status: FixReviewNeeded

Comment #1 on issue 4875 by [hidden email]: Polymorph  
WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly  
for left and right bottom corner, when corners are rounded.
http://code.google.com/p/pharo/issues/detail?id=4875

Replace UITheme>>drawWindowDiffuseDropShadowFor:on: with the following:


drawWindowDiffuseDropShadowFor: aSystemWindow on: aCanvas
        "Draw the diffuse drop shadow for the given window."
       
        |or b r o gc|
        or := self windowActiveDropShadowOffsetRectangleFor: aSystemWindow.
        o := or bottom.
        (aSystemWindow roundedCorners includesAnyOf: #(2 3))
                ifTrue: [o := o + 2].
        b := aSystemWindow bounds expandBy: or.
        gc := {Color black alpha: 0.6. Color transparent}.
        r := b topLeft extent: o asPoint.
        aCanvas
                fillRectangle: r
                fillStyle: ((GradientFillStyle colors: gc)
                                        origin: r bottomRight;
                                        direction: o@0;
                                        radial: true).
        r := b topLeft + (o@0) extent: (b width - o - o @ o).
        aCanvas
                fillRectangle: r
                fillStyle: ((GradientFillStyle colors: gc)
                                        origin: r bottomLeft;
                                        direction: 0@o negated).
        r := b topRight - (o@0) extent: o asPoint.
        aCanvas
                fillRectangle: r
                fillStyle: ((GradientFillStyle colors: gc)
                                        origin: r bottomLeft;
                                        direction: o@0;
                                        radial: true).
        r := b topRight + (o negated@o) extent: (o @ (b height - o - o)).
        aCanvas
                fillRectangle: r
                fillStyle: ((GradientFillStyle colors: gc)
                                        origin: r topLeft;
                                        direction: o@0).
        r := b bottomRight - o asPoint extent: o asPoint.
        aCanvas
                fillRectangle: r
                fillStyle: ((GradientFillStyle colors: gc)
                                        origin: r topLeft;
                                        direction: o@0;
                                        radial: true).
        r := b bottomLeft + (o@o negated) extent: (b width - o - o @ o).
        aCanvas
                fillRectangle: r
                fillStyle: ((GradientFillStyle colors: gc)
                                        origin: r topLeft;
                                        direction: 0@o).
        r := b bottomLeft - (0@o) extent: o asPoint.
        aCanvas
                fillRectangle: r
                fillStyle: ((GradientFillStyle colors: gc)
                                        origin: r topRight;
                                        direction: o@0;
                                        radial: true).
        r := b topLeft + (0@o) extent: (o @ (b height - o - o)).
        aCanvas
                fillRectangle: r
                fillStyle: ((GradientFillStyle colors: gc)
                                        origin: r topRight;
                                        direction: o negated@0)

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4875 in pharo: Polymorph WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly for left and right bottom corner, when corners are rounded.

pharo

Comment #2 on issue 4875 by [hidden email]: Polymorph  
WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly  
for left and right bottom corner, when corners are rounded.
http://code.google.com/p/pharo/issues/detail?id=4875

Works great in Pharo1.3 #13320. The shadow is now correct for windows with  
all four corners rounded and is still correct for windows with just the two  
top corners rounded.

In Pharo1.4a #14247 i cannot say, because in 1.4 at the moment - and since  
some time - there are no rounded corners at all. All corners are always  
straight.

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4875 in pharo: Polymorph WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly for left and right bottom corner, when corners are rounded.

pharo

Comment #3 on issue 4875 by [hidden email]: Polymorph  
WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly  
for left and right bottom corner, when corners are rounded.
http://code.google.com/p/pharo/issues/detail?id=4875

How does this fix relate to Issue 4783?

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4875 in pharo: Polymorph WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly for left and right bottom corner, when corners are rounded.

pharo
Updates:
        Labels: Milestone-1.4

Comment #4 on issue 4875 by [hidden email]: Polymorph  
WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly  
for left and right bottom corner, when corners are rounded.
http://code.google.com/p/pharo/issues/detail?id=4875

Indeed I tried and round corner does not work in 1.4

Stef

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4875 in pharo: Polymorph WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly for left and right bottom corner, when corners are rounded.

pharo
Updates:
        Status: Closed

Comment #5 on issue 4875 by [hidden email]: Polymorph  
WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly  
for left and right bottom corner, when corners are rounded.
http://code.google.com/p/pharo/issues/detail?id=4875

in 14270

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4875 in pharo: Polymorph WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly for left and right bottom corner, when corners are rounded.

pharo
Updates:
        Status: FixToInclude

Comment #6 on issue 4875 by [hidden email]: Polymorph  
WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly  
for left and right bottom corner, when corners are rounded.
http://code.google.com/p/pharo/issues/detail?id=4875

I revert it from now because I got a problem with MC not been able to  
parser info. So this is probably not related.

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4875 in pharo: Polymorph WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly for left and right bottom corner, when corners are rounded.

pharo
Updates:
        Status: Closed

Comment #7 on issue 4875 by [hidden email]: Polymorph  
WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly  
for left and right bottom corner, when corners are rounded.
http://code.google.com/p/pharo/issues/detail?id=4875

in 14274

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4875 in pharo: Polymorph WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly for left and right bottom corner, when corners are rounded.

pharo
Updates:
        Labels: MigratedToFogBugz

Comment #8 on issue 4875 by [hidden email]: Polymorph  
WindowActiveDropShadow for ShadowStyle: #diffuse does’t display correctly  
for left and right bottom corner, when corners are rounded.
http://code.google.com/p/pharo/issues/detail?id=4875#c8

Issue migrated to https://pharo.fogbugz.com/f/cases/4918

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker