Issue 492 in moose-technology: Glamour browsers do not release all subscriptions to announcer objects

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
28 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: Issue 492 in moose-technology: Glamour browsers do not release all subscriptions to announcer objects

moose-technology
Updates:
        Labels: -Milestone-4.4

Comment #20 on issue 492 by [hidden email]: Glamour browsers do not  
release all subscriptions to announcer objects
http://code.google.com/p/moose-technology/issues/detail?id=492

(No comment was entered for this change.)

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Issue 492 in moose-technology: Glamour browsers do not release all subscriptions to announcer objects

moose-technology

Comment #21 on issue 492 by [hidden email]: Glamour browsers do not  
release all subscriptions to announcer objects
http://code.google.com/p/moose-technology/issues/detail?id=492

looks like adding a #makeWeak send to  
GLMUpdateAction>>#registerInPresentation makes the bahavior  better (I  
don't know if it corrects the problem, but it reduces the announcement  
subscription propagation a lot).

GLMUpdateAction>>#registerInPresentation
        self announcerObjects do: [: announcerObject |
                announcerObject notNil ifTrue: [
                        (announcerObject on: self announcement send: #actOn: to: self) makeWeak.
                       
                        "we remember the announcer object to be able to
                        unregister from it when the presentation goes away"
                        self presentation registeredAnnouncers add: announcerObject ] ]

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Issue 492 in moose-technology: Glamour browsers do not release all subscriptions to announcer objects

moose-technology

Comment #22 on issue 492 by [hidden email]: Glamour browsers do not  
release all subscriptions to announcer objects
http://code.google.com/p/moose-technology/issues/detail?id=492

anyway, there are still internal announcements who uses the on:do: form  
which can not be maked as weak (because of the ephemerons issue), and we  
need to check how to clean those... well, maybe tomorrow :)

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Issue 492 in moose-technology: Glamour browsers do not release all subscriptions to announcer objects

moose-technology
Updates:
        Labels: Milestone-4.5

Comment #23 on issue 492 by [hidden email]: Glamour browsers do not  
release all subscriptions to announcer objects
http://code.google.com/p/moose-technology/issues/detail?id=492

Please commit the makeWeak fix. This is needed. It would be great to have a  
test that at least reveals the problem ... but we do not have it right now.

Regarding the internal announcements, these should not be problematic  
because they do not link to the actual model (hopefully :)

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Issue 492 in moose-technology: Glamour browsers do not release all subscriptions to announcer objects

moose-technology
Updates:
        Labels: -Milestone-4.5 Milestone-4.6

Comment #24 on issue 492 by [hidden email]: Glamour browsers do not  
release all subscriptions to announcer objects
http://code.google.com/p/moose-technology/issues/detail?id=492

(No comment was entered for this change.)

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Issue 492 in moose-technology: Glamour browsers do not release all subscriptions to announcer objects

moose-technology
Updates:
        Status: Fixed

Comment #25 on issue 492 by [hidden email]: Glamour browsers do not  
release all subscriptions to announcer objects
http://code.google.com/p/moose-technology/issues/detail?id=492

This is now fixed. Hopefully :)

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Issue 492 in moose-technology: Glamour browsers do not release all subscriptions to announcer objects

EstebanLM
this is really cool, great Tudor!

sorry I didn't find time to help a little more with this... but well, at least I can help by testing it :)

cheers,
Esteban

El 14/07/2011, a las 7:15a.m., [hidden email] escribió:

> Updates:
> Status: Fixed
>
> Comment #25 on issue 492 by [hidden email]: Glamour browsers do not release all subscriptions to announcer objects
> http://code.google.com/p/moose-technology/issues/detail?id=492
>
> This is now fixed. Hopefully :)
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Issue 492 in moose-technology: Glamour browsers do not release all subscriptions to announcer objects

Tudor Girba-2
Hi Esteban,

Testing this would be very helpful :)

Cheers,
Doru


On 14 Jul 2011, at 14:37, Esteban Lorenzano wrote:

> this is really cool, great Tudor!
>
> sorry I didn't find time to help a little more with this... but well, at least I can help by testing it :)
>
> cheers,
> Esteban
>
> El 14/07/2011, a las 7:15a.m., [hidden email] escribió:
>
>> Updates:
>> Status: Fixed
>>
>> Comment #25 on issue 492 by [hidden email]: Glamour browsers do not release all subscriptions to announcer objects
>> http://code.google.com/p/moose-technology/issues/detail?id=492
>>
>> This is now fixed. Hopefully :)
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"Every thing should have the right to be different."




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
12