Issue 4941 in pharo: Failing Test: ArrayTest

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4941 in pharo: Failing Test: ArrayTest

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-FailingTest Milestone-1.4

New issue 4941 by [hidden email]: Failing Test: ArrayTest
http://code.google.com/p/pharo/issues/detail?id=4941

CollectionsTests.Arrayed.ArrayTest.testComplexIsSelfEvaluating
CollectionsTests.Arrayed.ArrayTest.testPrinting


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4941 in pharo: Failing Test: ArrayTest

pharo

Comment #1 on issue 4941 by [hidden email]: Failing Test: ArrayTest
http://code.google.com/p/pharo/issues/detail?id=4941

As for #testPrinting, the test was failing in the following line:

        self assert: nonSEarray2 printString = '{(#Array->Array)}'
We don't want those brackets, so we removed them:
        self assert: nonSEarray2 printString = '{#Array->Array}'
and that does the trick. Typo error :P

As for #testComplexIsEvaluating, there were problems with two objects in  
the array:
RunArray new: 5 withAll: #bold
(0@0 extent: 1@1)->0. "when you send #printString you get 0@0 corner: 1@1  
->0 which has precedence problems"
So, for the sake of the test itself, we removed the RunArray instance and  
change the association for 'hola'-> 0.  1@1 extent: 2@3.(so as to keep an  
association and a rectangle in the array). But there's a deeper question  
here, what should we do with printString for rectangles? It's clear we  
don't want the brackets all the times, so maybe a solution could be to  
define a new message which uses self printString and then override it for  
Rectangle instances...

Here is the slice
Name: SLICE-Issue-4941-Failing-Test-Array-Test-ClaraAllende.1
Author: ClaraAllende
Time: 2 November 2011, 6:26:46 pm
UUID: d70a78a7-2a69-df4c-bbee-13415ec19543
Ancestors:
Dependencies: CollectionsTests-ClaraAllende.533

Refactored #testPrinting and #testComplexIsSelfEvaluating




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4941 in pharo: Failing Test: ArrayTest

pharo
Updates:
        Status: FixReviewNeeded

Comment #2 on issue 4941 by [hidden email]: Failing Test: ArrayTest
http://code.google.com/p/pharo/issues/detail?id=4941

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4941 in pharo: Failing Test: ArrayTest

pharo

Comment #3 on issue 4941 by [hidden email]: Failing Test: ArrayTest
http://code.google.com/p/pharo/issues/detail?id=4941

Clara it is not clear that you included your package in the slice. I will  
check if I can fix that directly


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4941 in pharo: Failing Test: ArrayTest

pharo

Comment #4 on issue 4941 by [hidden email]: Failing Test: ArrayTest
http://code.google.com/p/pharo/issues/detail?id=4941

Ok, let me know if I have to republish the slice... I'm struggling with the  
ISP to get my internet back :(


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4941 in pharo: Failing Test: ArrayTest

pharo
Updates:
        Status: Closed

Comment #5 on issue 4941 by [hidden email]: Failing Test: ArrayTest
http://code.google.com/p/pharo/issues/detail?id=4941

Ok I got them :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4941 in pharo: Failing Test: ArrayTest

pharo

Comment #6 on issue 4941 by [hidden email]: Failing Test: ArrayTest
http://code.google.com/p/pharo/issues/detail?id=4941

in 14221


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4941 in pharo: Failing Test: ArrayTest

pharo

Comment #7 on issue 4941 by [hidden email]: Failing Test: ArrayTest
http://code.google.com/p/pharo/issues/detail?id=4941

Oh, this seems much related to Issue 4943


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker