Issue 4944 in pharo: Failing Test: RBSmalllintTest

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.4 Type-FailingTest

New issue 4944 by [hidden email]: Failing Test: RBSmalllintTest
http://code.google.com/p/pharo/issues/detail?id=4944

https://ci.lille.inria.fr/pharo/job/Pharo%201.4%20Tests-Unix/lastCompletedBuild/testReport/

Refactoring.Tests.Critics.RBSmalllintTest.testBadMessage


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4944 by [hidden email]: Failing Test:  
RBSmalllintTest
http://code.google.com/p/pharo/issues/detail?id=4944

Name: SLICE-Issue-4944-Failing-Test-RBSmalllintTest-pnp.2
Author: pnp
Time: 2 November 2011, 3:57:49 pm
UUID: 0a3f5cef-895b-46a2-a5b5-96cf5d34a280
Ancestors: SLICE-Issue-4944-Failing-Test-RBSmalllintTest-pnp.1
Dependencies: Refactoring-Critics-pnp.13

Added #removeForward: as a bad selector in RBBadMessageRule


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #2 on issue 4944 by [hidden email]: Failing Test:  
RBSmalllintTest
http://code.google.com/p/pharo/issues/detail?id=4944

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4944 by [hidden email]: Failing Test:  
RBSmalllintTest
http://code.google.com/p/pharo/issues/detail?id=4944

#badSelectors is also implemented in RBBasicLintTestRule class.
Shouldn't we merge both methods?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: renggli

Comment #4 on issue 4944 by [hidden email]: Failing Test:  
RBSmalllintTest
http://code.google.com/p/pharo/issues/detail?id=4944

Thanks nicolas.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4944 by renggli: Failing Test: RBSmalllintTest
http://code.google.com/p/pharo/issues/detail?id=4944

It does not fail for me. What is the problem?

For RBBasicLintTestRule: This is a mock class, a copy of the original  
RBBasicLintRule used by various tests to test refactorings, changes, lint  
rules, etc. It was copied at some point (around 2002 or so) to be able to  
move the system forward without having to rewrite the tests all the time.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4944 by [hidden email]: Failing Test:  
RBSmalllintTest
http://code.google.com/p/pharo/issues/detail?id=4944

Mariano replaces all #become: by #becomeForward:, even the one in  
#badMessage.

Now this uncovers that becomeForward: is missing from the list of bas  
selectors.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #7 on issue 4944 by [hidden email]: Failing Test:  
RBSmalllintTest
http://code.google.com/p/pharo/issues/detail?id=4944

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #8 on issue 4944 by [hidden email]: Failing Test:  
RBSmalllintTest
http://code.google.com/p/pharo/issues/detail?id=4944

in 14253


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker