Issue 4945 in pharo: Weird Settings filtering

Status: Accepted
Owner: marianopeck
CC: [hidden email]

New issue 4945 by marianopeck: Weird Settings filtering
http://code.google.com/p/pharo/issues/detail?id=4945

Hi Alain. I found something weird with the filtering of the Settings  
browser. I installed keymapping by

Gofer new
squeaksource: 'ShortWays';
package: 'ConfigurationOfKeymapping';
load.

(ConfigurationOfKeymapping project version: #bleedingEdge) load

Now...if you open the settings browser you see the category "Keymappings".  
But if I go to the input field, type "keymap" and hit enter, I see a result  
that contains "Keymapping" but not its item.
So...it seems that the settings searches in the items of the category but  
not in the category name. So I wonder.... show we show the list if a  
category name matches?

thanks


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4945 by [hidden email]: Weird Settings filtering
http://code.google.com/p/pharo/issues/detail?id=4945

Thanks Mariano for opening this issue.
I will fixe that.
when a setting node with children is found then its children should also be  
shown.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Labels: Milestone-1.3 Milestone-1.4

Comment #2 on issue 4945 by [hidden email]: Weird Settings filtering
http://code.google.com/p/pharo/issues/detail?id=4945

for 1.4:
SLICE-Issue-4945-Weird-Settings-filtering-AlainPlantec.1

for 1.3:
attached cs

Attachments:
        Issue-4945-Weird-Settings-filtering.1.cs  403 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Bug

Comment #3 on issue 4945 by [hidden email]: Weird Settings filtering
http://code.google.com/p/pharo/issues/detail?id=4945

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4945 by marianopeck: Weird Settings filtering
http://code.google.com/p/pharo/issues/detail?id=4945

Hi Alain. Thanks for the fix. Now I have just test it, and it doesn't work  
for the particular example I was talking about. This is because I was  
typing "keymap" and in Keymapping, the settings are not in its immediate  
children, but instead there is a children called "Editors" and then, the  
children of "Editors" contain the settings for the shortcuts.  So... with  
your fix I can only see "Editors".

Now.... there are two possibities: if there is a match in one item, then  
show ALL its children and the children of the children....so, the whole  
tree. Or don't do that. I don't pretend to be what I need in this example,  
because I can imagine that this could be not desired in other examples?  
what do you think?

thanks!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4945 by [hidden email]: Weird Settings filtering
http://code.google.com/p/pharo/issues/detail?id=4945

arrrr.
so try this cs for 1.3  and let me know

Attachments:
        Issue-4945-Weird-Settings-filtering.4.cs  913 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4945 by marianopeck: Weird Settings filtering
http://code.google.com/p/pharo/issues/detail?id=4945

Thanks Alain for the quick fix. Yes, that one works perfect.
Now...should this be the default behavior for all cases? what do you think?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4945 by [hidden email]: Weird Settings filtering
http://code.google.com/p/pharo/issues/detail?id=4945

let do it simple, so yes.

for 1.4: SLICE-Issue-4945-Weird-Settings-filtering-AlainPlantec.2
for 1.3: attached in previous post, Issue-4945-Weird-Settings-filtering.4.cs




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4945 by marianopeck: Weird Settings filtering
http://code.google.com/p/pharo/issues/detail?id=4945

Thanks Alain. Everything works perfect now. I change to FixToInclude.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #9 on issue 4945 by marianopeck: Weird Settings filtering
http://code.google.com/p/pharo/issues/detail?id=4945

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 4945 by [hidden email]: Weird Settings filtering
http://code.google.com/p/pharo/issues/detail?id=4945

in 14214

TODO: 13


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #11 on issue 4945 by [hidden email]: Weird Settings filtering
http://code.google.com/p/pharo/issues/detail?id=4945

in 13320


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker