Issue 4953 in pharo: Toggle break on entry is broken

Status: Accepted
Owner: [hidden email]

New issue 4953 by [hidden email]: Toggle break on entry is broken
http://code.google.com/p/pharo/issues/detail?id=4953

Open a Browser.
Select class PSMCPatchBrowser and method browseVersions
(you see I'm still trying to debug it, quelle pugnacité)
Select pop-up menu 'toggle break on entry'

Open a MC browser, select a dirty packages, press button 'Changes'
In the diff tool select a method and pop-up menu 'Versions...'
That's it, emergency evaluator...

-------

Now for fun, open a File Browser, select PharoDebug.log, of my god  
4,810,592 bytes, try to get the entire contents because you're just the guy  
that like to play and because you wish to copy the end of the file in this  
report with 100% Pharo tools. Well go to the fridge, take one beer, no  
maybe two beers if you are far-sighted.

Oops 5 beers, you're drunk, and the file still you cannot read.
CMD+SHIFT+. doesn't produce much reaction.
Pomme + forcer à quitter is your last option.
Great job, developing in Pharo is real fun ;)

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Bug Milestone-1.4

Comment #1 on issue 4953 by [hidden email]: Toggle break on entry is  
broken
http://code.google.com/p/pharo/issues/detail?id=4953

Bad luck, the emergency does not write into PharoDebug.log...
Maybe a Screen capture might help...

Attachments:
        Capture d’écran 2011-10-30 à 22.44.49.png  283 KB

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4953 by [hidden email]: Toggle break on entry is  
broken
http://code.google.com/p/pharo/issues/detail?id=4953

So the emergency is due to a Text in the debugger stack list...
(something used to highlight break on entry in red ?)

As a workaround, I protected
Debugger>>contextStackList
        "Answer the array of contexts."
        ^ contextStackList collect: [:string || tokens |
                        tokens := string asString subStrings: '>>'.
                        {(self buildClassNameFor: tokens first). tokens second}]

Would it be better to avoid putting a Text?



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4953 by [hidden email]: Toggle break on entry is  
broken
http://code.google.com/p/pharo/issues/detail?id=4953

Note: it's not PSMCPatchBrowser, it's PSMCPatchMorph


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4953 by [hidden email]: Toggle break on entry is  
broken
http://code.google.com/p/pharo/issues/detail?id=4953

Yep, it's not red, it's bold:

MethodContext>>printString
        "Answer an emphasized string in case of a breakpoint method"

        ^(self method notNil and: [self method hasBreakpoint])
                ifTrue:[(super printString , ' [break]') asText allBold]
                ifFalse:[super printString]

I think that printString should not return a Text, or is it printText?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Labels: Importance-High

Comment #5 on issue 4953 by [hidden email]: Toggle break on entry is  
broken
http://code.google.com/p/pharo/issues/detail?id=4953

Name: SLICE-Issue-4953-Toggle-break-on-entry-is-broken-nice.1
Author: nice
Time: 31 October 2011, 11:54:18 pm
UUID: 0d97fa22-2b81-4f60-a613-e652dd63eb00
Ancestors:
Dependencies: Kernel-nice.963

Fix issue 4953, toggle break on entry

MethodContext with break point was trying to print with bold attribute...
Unfortunately,
1) tools changed so this is useless
2) it is bad behaved to anser a Text to printString
3) this is causing a recursive debugger error (I think while writing to the  
error log)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4953 by [hidden email]: Toggle break on entry is  
broken
http://code.google.com/p/pharo/issues/detail?id=4953

thanks I will review your fix.
This part of the system is ugly.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #7 on issue 4953 by [hidden email]: Toggle break on entry is  
broken
http://code.google.com/p/pharo/issues/detail?id=4953

Yes we will have to rebuild this part once the others are done.
So I integrated your solution in 14216


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker