Issue 4965 in pharo: Choosing from "Unknown variable... Please correct" list has no effect

Status: Accepted
Owner: [hidden email]

New issue 4965 by [hidden email]: Choosing from "Unknown variable...  
Please correct" list has no effect
http://code.google.com/p/pharo/issues/detail?id=4965

Pharo1.3 rc
Latest update: #13318

Steps to reproduce:
1. In OB code pane, misspell an instance variable e.g. "outPut" instead  
of "output"
2. In "Unknown variable... Please correct" menu, choose the instance  
variable

The code is saved with the still-incorrect and nonexistent "outPut",  
highlighted red.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #1 on issue 4965 by [hidden email]: Choosing from "Unknown  
variable... Please correct" list has no effect
http://code.google.com/p/pharo/issues/detail?id=4965

can you check in 2.0?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Accepted
        Labels: Type-Nautilus Milestone-2.0 Importance-High

Comment #2 on issue 4965 by [hidden email]: Choosing from "Unknown  
variable... Please correct" list has no effect
http://code.google.com/p/pharo/issues/detail?id=4965

Yes, it's still happening. Here are new, more specific steps to cause it in  
Nautilus:

1. Type a new method in the code pane* (I added it to RBPragmaNode in my  
experiment)
   a. As the body, just return an instance variable, but leave one character  
off the end.
3. In "Unknown variable... Please correct" menu, choose the instance  
variable

* For example:
     RBPragmaNode>>myMethod
        ^ selecto.

You will have a saved method with a syntax error (misspelled instVar)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Type-Nautilus Type-Bug Target-Nautilus

Comment #3 on issue 4965 by [hidden email]: Choosing from "Unknown  
variable... Please correct" list has no effect
http://code.google.com/p/pharo/issues/detail?id=4965

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4965 by [hidden email]: Choosing from "Unknown  
variable... Please correct" list has no effect
http://code.google.com/p/pharo/issues/detail?id=4965

The classic browser (Browser) actually does the same.

Keep digging


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4965 by [hidden email]: Choosing from "Unknown  
variable... Please correct" list has no effect
http://code.google.com/p/pharo/issues/detail?id=4965

It seems to come from Parser>>#parse: sourceStream class: class category:  
aCategory noPattern: noPattern context: ctxt notifying: req ifFail: aBlock

at the end, you have:
methNode sourceText: s.

So here, it set the methodNode source code from the original stream (source  
code), but in the mid time, if the variable name was wrong, the text morph  
is corrected, but not the Compiler sourceStream, so it set back the  
pre-correction text...

And I do not want to be the guy who creates a dependency from the Compiler  
to Morphic (because you have access to the morph, so I could ask it its  
text at the end, but ...)



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email] [hidden email]

Comment #6 on issue 4965 by [hidden email]: Choosing from "Unknown  
variable... Please correct" list has no effect
http://code.google.com/p/pharo/issues/detail?id=4965

I invoke thinkers :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4965 by [hidden email]: Choosing from "Unknown  
variable... Please correct" list has no effect
http://code.google.com/p/pharo/issues/detail?id=4965

Ok, I just saw that such a depency already exists since 2 lines above you  
can find

requestor text string readStream

so let's do the same :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #8 on issue 4965 by [hidden email]: Choosing from "Unknown  
variable... Please correct" list has no effect
http://code.google.com/p/pharo/issues/detail?id=4965

Slice in the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #9 on issue 4965 by [hidden email]: Choosing from "Unknown  
variable... Please correct" list has no effect
http://code.google.com/p/pharo/issues/detail?id=4965

Works in 20443.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #10 on issue 4965 by [hidden email]: Choosing from "Unknown  
variable... Please correct" list has no effect
http://code.google.com/p/pharo/issues/detail?id=4965

in 2.0 447


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker