Issue 4970 in pharo: [ENH]: Check out calendar chooser morph from Squeak

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 4970 in pharo: [ENH]: Check out calendar chooser morph from Squeak

pharo
Status: Accepted
Owner: [hidden email]

New issue 4970 by [hidden email]: [ENH]: Check out calendar chooser  
morph from Squeak
http://code.google.com/p/pharo/issues/detail?id=4970

Very cool/profressional-looking. Discussion underway at  
http://forum.world.st/Calendar-Chooser-td3980015.html#a3983915 about adding  
it to Squeak. MIT licensed.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4970 in pharo: [ENH]: Check out calendar chooser morph from Squeak

pharo
Updates:
        Status: Invalid

Comment #1 on issue 4970 by [hidden email]: [ENH]: Check out  
calendar chooser morph from Squeak
http://code.google.com/p/pharo/issues/detail?id=4970

Do we need that in the system?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4970 in pharo: [ENH]: Check out calendar chooser morph from Squeak

pharo
Updates:
        Status: HumanReviewNeeded
        Labels: Type-Enh Difficulty-Easy

Comment #2 on issue 4970 by [hidden email]: [ENH]: Check out  
calendar chooser morph from Squeak
http://code.google.com/p/pharo/issues/detail?id=4970

I think that it is more standard of a widget than a color chooser, which we  
currently have. Let's either remove all the widgets, or support as many  
that people tend to use as possible.

I fixed it up for Pharo 2.0, using announcements.

Slice in inbox: Morphic-SeanDeNigris.1327

- Port Squeak's CalendarChooserMorph to Pharo 2.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4970 in pharo: [ENH]: Check out calendar chooser morph from Squeak

pharo

Comment #3 on issue 4970 by [hidden email]: [ENH]: Check out  
calendar chooser morph from Squeak
http://code.google.com/p/pharo/issues/detail?id=4970

Cool!
Yes we should have better widgets and also remove some of the ones we have!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4970 in pharo: [ENH]: Check out calendar chooser morph from Squeak

pharo

Comment #4 on issue 4970 by [hidden email]: [ENH]: Check out  
calendar chooser morph from Squeak
http://code.google.com/p/pharo/issues/detail?id=4970

I think that in the future we will have a metacello configuration and there  
we will be able to have nice separate packages.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4970 in pharo: [ENH]: Check out calendar chooser morph from Squeak

pharo

Comment #5 on issue 4970 by [hidden email]: [ENH]: Check out  
calendar chooser morph from Squeak
http://code.google.com/p/pharo/issues/detail?id=4970

I did a code review and integrated it in 20492


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4970 in pharo: [ENH]: Check out calendar chooser morph from Squeak

pharo
Updates:
        Status: WorkNeeded

Comment #6 on issue 4970 by [hidden email]: [ENH]: Check out  
calendar chooser morph from Squeak
http://code.google.com/p/pharo/issues/detail?id=4970

Sean I published a new version.
- Now the following points should be addressed:
      - reference to ListChooser in handleYearTouched, handleMonthNameTouched
      - reference to target and actionSelector in choose:

choose: aDate

        self date: aDate.
        target ifNotNil: [
                target perform: actionSelector with: aDate.
                self delete ]

CalendarChooserMorph openOn: Date today

raised a red box of death :)



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4970 in pharo: [ENH]: Check out calendar chooser morph from Squeak

pharo
Updates:
        Status: FixReviewNeeded

Comment #7 on issue 4970 by [hidden email]: [ENH]: Check out  
calendar chooser morph from Squeak
http://code.google.com/p/pharo/issues/detail?id=4970

Oops, must've packaged an old version in the slice... I fixed all that...

Fix in inbox:  
SLICE-Issue-4970-ENH-Check-out-calendar-chooser-morph-from-Squeak-SeanDeNigris.2

- Remove reference to undeclared ListChooser in handleYearTouched &  
handleMonthNameTouched
- Remove remnants of event-based callbacks (we're using announcements  
instead), including #choose:
- Small cleanups


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4970 in pharo: [ENH]: Check out calendar chooser morph from Squeak

pharo

Comment #8 on issue 4970 by [hidden email]: [ENH]: Check out  
calendar chooser morph from Squeak
http://code.google.com/p/pharo/issues/detail?id=4970

Thanks this is cool to pair program at distance like that :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4970 in pharo: [ENH]: Check out calendar chooser morph from Squeak

pharo
Updates:
        Cc: [hidden email]

Comment #9 on issue 4970 by [hidden email]: [ENH]: Check out  
calendar chooser morph from Squeak
http://code.google.com/p/pharo/issues/detail?id=4970

Yes! I was thinking if it would be possible for the Santiago sprint by  
Skype or even like this on IRC or whatever...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4970 in pharo: [ENH]: Check out calendar chooser morph from Squeak

pharo

Comment #10 on issue 4970 by [hidden email]: [ENH]: Check out  
calendar chooser morph from Squeak
http://code.google.com/p/pharo/issues/detail?id=4970

yes let us know we can have a skype open.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 4970 in pharo: [ENH]: Check out calendar chooser morph from Squeak

pharo

Comment #11 on issue 4970 by [hidden email]: [ENH]: Check out  
calendar chooser morph from Squeak
http://code.google.com/p/pharo/issues/detail?id=4970

Sean this is strange because even in the version 2 you did include the  
changes I did.
I will go over them and merge.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker