Issue 5007 in pharo: On TextEditorDialogWindow

Status: FixReviewNeeded
Owner: [hidden email]
Labels: Type-Feature Milestone-1.4

New issue 5007 by [hidden email]: On TextEditorDialogWindow
http://code.google.com/p/pharo/issues/detail?id=5007

Recategorization + add a setting which allow you to valid the text when you  
accept it.

So if you do Cmd+s, it accept the text, the the window selection

Attachments:
        DialogWindowAcceptOnSave.1.cs  2.0 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5007 by [hidden email]: On TextEditorDialogWindow
http://code.google.com/p/pharo/issues/detail?id=5007

I'm not clear what the original shortcoming was, and how this helps. Will  
you give a reproducible use case?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Workneeded

Comment #2 on issue 5007 by [hidden email]: On TextEditorDialogWindow
http://code.google.com/p/pharo/issues/detail?id=5007

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #3 on issue 5007 by [hidden email]: On TextEditorDialogWindow
http://code.google.com/p/pharo/issues/detail?id=5007

Right now, if you evaluate

UITheme current
textEditorIn: World
text: 'Enter a text'
title: 'Editor'
entryText: 'Test'
entryHeight: 300.

you get an editor dialog window, and if you change the text, and accept it  
(cmd+s), it will just accept the text, and then you will have to click on  
OK to validate.

With this fix, if you turn on the setting, if you modify the text, then  
accept it (cmd+s), it will validate it (it emulates the ok click).


I hope it's clearer now :)

If not, I can do a video :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5007 by [hidden email]: On TextEditorDialogWindow
http://code.google.com/p/pharo/issues/detail?id=5007

Now I see. I can verify it works. What's the use case for keeping "accept  
but don't verify" via setting? Why not just make it always verify on  
accepting?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #5 on issue 5007 by [hidden email]: On TextEditorDialogWindow
http://code.google.com/p/pharo/issues/detail?id=5007

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5007 by [hidden email]: On TextEditorDialogWindow
http://code.google.com/p/pharo/issues/detail?id=5007

It prevents some people to have to change their habits :)
What we can do is to change the default value of the setting :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 5007 by [hidden email]: On TextEditorDialogWindow
http://code.google.com/p/pharo/issues/detail?id=5007

in 14234


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker