Issue 5043 in pharo: Remove TextAction and subclasses

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 5043 in pharo: Remove TextAction and subclasses

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-Cleanup

New issue 5043 by [hidden email]: Remove TextAction and subclasses
http://code.google.com/p/pharo/issues/detail?id=5043

Pharo1.4a
Latest update: #14239

They seem to be unused legacy classes.

See discussion at http://forum.world.st/COTDC-86-TextURL-td4119838.html


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5043 in pharo: Remove TextAction and subclasses

pharo
Updates:
        Status: FixReviewNeeded

Comment #1 on issue 5043 by [hidden email]: Remove TextAction and  
subclasses
http://code.google.com/p/pharo/issues/detail?id=5043

Fix in inbox:  
SLICE-Issue-5043-Remove-TextAction-and-subclasses-SeanDeNigris.1

Removed TextAction and its subclasses, and all references in the image.

Someone with knowledge of RunArray and RemoteString should check this. I  
removed code that referenced the removed classes, but don't understand  
RunArray and RemoteString well enough to be sure that I didn't mess  
anything up. All RunArray's tests still pass, but RemoteString didn't seem  
to have any.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5043 in pharo: Remove TextAction and subclasses

pharo
Updates:
        Labels: Milestone-1.4

Comment #2 on issue 5043 by [hidden email]: Remove TextAction and  
subclasses
http://code.google.com/p/pharo/issues/detail?id=5043

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5043 in pharo: Remove TextAction and subclasses

pharo
Updates:
        Status: FixToInclude

Comment #3 on issue 5043 by [hidden email]: Remove TextAction and  
subclasses
http://code.google.com/p/pharo/issues/detail?id=5043

test is ok can be integrate, just a small clean can be performed the method  
SHTextStylerST80>>#unstyledTextFrom: aText can be removed (just reference  
to super class),


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5043 in pharo: Remove TextAction and subclasses

pharo
Updates:
        Status: Closed

Comment #4 on issue 5043 by [hidden email]: Remove TextAction and  
subclasses
http://code.google.com/p/pharo/issues/detail?id=5043

For now we will keep them


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker