Issue 5084 in pharo: Remove textStyle FileOut

Status: FixReviewNeeded
Owner: [hidden email]
Labels: Type-Cleanup Milestone-1.4

New issue 5084 by [hidden email]: Remove textStyle FileOut
http://code.google.com/p/pharo/issues/detail?id=5084

There are lots of unsent and unused methods in TextStyle, mostly related to
  - filing out TextStyles
  - user interface methods that have no senders.

Can these be safely removed?

I would like to remove:

TextStyle class removeSelector: #chooseTTCFontSize:!
TextStyle class removeSelector: #collectionFromCompressedMIMEString:!
TextStyle class removeSelector: #fontMenuForStyle:target:selector:!
TextStyle class removeSelector:  
#fontMenuForStyle:target:selector:highlight:!
TextStyle class removeSelector: #importFontsFromStyleFiles!
TextStyle class removeSelector: #modalStyleSelectorWithTitle:!
TextStyle class removeSelector: #promptForFont:andSendTo:withSelector:!
TextStyle class removeSelector:  
#promptForFont:andSendTo:withSelector:highlight:!
TextStyle class removeSelector:  
#writeSF2FamilyNamed:inDirectory:toChangeSet:!
TextStyle class removeSelector: #writeStyle:named:toChangeSet:!
TextStyle removeSelector: #compressedMIMEEncodedStream!
TextStyle removeSelector: #makeArrows!



Attachments:
        TextStyleFileOutClean.1.cs  2.4 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #1 on issue 5084 by [hidden email]: Remove textStyle FileOut
http://code.google.com/p/pharo/issues/detail?id=5084

Marcus I will also try to have a look.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5084 by [hidden email]: Remove textStyle FileOut
http://code.google.com/p/pharo/issues/detail?id=5084

For me it's ok, I am waiting for Ulysse to run tests.


But maybe we should removed TextStyle en general
(a lot of unsent methods, most of the users asks for defaultFont) ^^


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #3 on issue 5084 by [hidden email]: Remove textStyle FileOut
http://code.google.com/p/pharo/issues/detail?id=5084

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #4 on issue 5084 by [hidden email]: Remove textStyle FileOut
http://code.google.com/p/pharo/issues/detail?id=5084

in 14260


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker