Issue 5095 in pharo: Monticello snapshotting does lots of unnecessary screen updates

Status: Accepted
Owner: renggli

New issue 5095 by renggli: Monticello snapshotting does lots of unnecessary  
screen updates
http://code.google.com/p/pharo/issues/detail?id=5095

Showing on the screen as each method is read causes thousands of  
unnecessary screen updates, that slow the process down and does not provide  
additional value to the static message previously shown.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.4 Type-Bug

Comment #1 on issue 5095 by renggli: Monticello snapshotting does lots of  
unnecessary screen updates
http://code.google.com/p/pharo/issues/detail?id=5095

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5095 by [hidden email]: Monticello snapshotting  
does lots of unnecessary screen updates
http://code.google.com/p/pharo/issues/detail?id=5095

Indeed. I spent some time to see how we can reduce that because this is  
really annoying. I started to clean ProgressBarMorph.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5095 by renggli: Monticello snapshotting does lots of  
unnecessary screen updates
http://code.google.com/p/pharo/issues/detail?id=5095

The problem would be solved by reverting the changes to MCPackageLoader.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 5095 by [hidden email]: Monticello snapshotting  
does lots of unnecessary screen updates
http://code.google.com/p/pharo/issues/detail?id=5095

Yes I will do that.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5095 by [hidden email]: Monticello snapshotting  
does lots of unnecessary screen updates
http://code.google.com/p/pharo/issues/detail?id=5095

any idea where was the changes. I thought it was in the basicLoad method  
but after checking all the changes in 1.4 I could not find any change done  
on this method.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5095 by [hidden email]: Monticello snapshotting  
does lots of unnecessary screen updates
http://code.google.com/p/pharo/issues/detail?id=5095

Probably in MCPackage>>snapshot.
I should check that now.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5095 by renggli: Monticello snapshotting does lots of  
unnecessary screen updates
http://code.google.com/p/pharo/issues/detail?id=5095

Yes, this used to be:

MCPacakge>>snapshot
        | packageInfo definitions categories |
        packageInfo := self packageInfo.
        definitions := OrderedCollection new.
        categories := packageInfo systemCategories.
        categories isEmpty ifFalse: [ definitions add: (MCOrganizationDefinition  
categories: categories) ].
        packageInfo methods do: [:ea | definitions add: ea asMCMethodDefinition]  
displayingProgress: 'Snapshotting methods...'.
        packageInfo overriddenMethods
                do: [:ea | definitions add:
                                        (packageInfo changeRecordForOverriddenMethod: ea) asMCMethodDefinition]
                displayingProgress: 'Searching for overrides...'.
        packageInfo classes do: [:ea | definitions addAll: ea classDefinitions]  
displayingProgress: 'Snapshotting classes...'.
        (packageInfo respondsTo: #hasPreamble) ifTrue: [
                packageInfo hasPreamble ifTrue: [definitions add: (MCPreambleDefinition  
from: packageInfo)].
                packageInfo hasPostscript ifTrue: [definitions add:  
(MCPostscriptDefinition from: packageInfo)].
                packageInfo hasPreambleOfRemoval ifTrue: [definitions add:  
(MCRemovalPreambleDefinition from: packageInfo)].
                packageInfo hasPostscriptOfRemoval ifTrue: [definitions add:  
(MCRemovalPostscriptDefinition from: packageInfo)]].
        ^ MCSnapshot fromDefinitions: definitions



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 5095 by [hidden email]: Monticello snapshotting  
does lots of unnecessary screen updates
http://code.google.com/p/pharo/issues/detail?id=5095

Yes I was doing a file out.
Now I really dislike all these feedback stuff.

Now I'm surprised that there was

packageInfo methods do: [:ea | definitions add: ea asMCMethodDefinition]  
displayingProgress: 'Snapshotting methods...'.

because in my fix I have

snapshot
        | packageInfo definitions categories |
        packageInfo := self packageInfo.
        definitions := OrderedCollection new.
        categories := packageInfo systemCategories.
        categories isEmpty
                ifFalse: [ definitions add: (MCOrganizationDefinition categories:  
categories) ].
               
        packageInfo methods
                do: [:ea | definitions add: ea asMCMethodDefinition].
               
        packageInfo overriddenMethods
                do: [:ea | definitions add:
                                        (packageInfo changeRecordForOverriddenMethod: ea) asMCMethodDefinition]
                displayingProgress: [ :ea| 'Searching for overrides in ', ea asString ].
               
        packageInfo classes
                do: [:ea | definitions addAll: ea classDefinitions]
                displayingProgress: [ :ea| 'Snapshotting class ', ea asString ].
               
        (packageInfo respondsTo: #hasPreamble) ifTrue: [
                packageInfo hasPreamble
                        ifTrue: [definitions add: (MCPreambleDefinition from: packageInfo)].
                packageInfo hasPostscript
                        ifTrue: [definitions add: (MCPostscriptDefinition from: packageInfo)].
                packageInfo hasPreambleOfRemoval
                        ifTrue: [definitions add: (MCRemovalPreambleDefinition from:  
packageInfo)].
                packageInfo hasPostscriptOfRemoval
                        ifTrue: [definitions add: (MCRemovalPostscriptDefinition from:  
packageInfo)]].
        ^ MCSnapshot fromDefinitions: definitions


I understand before the progress bar showed up but without indication




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 5095 by [hidden email]: Monticello snapshotting  
does lots of unnecessary screen updates
http://code.google.com/p/pharo/issues/detail?id=5095

(No comment was entered for this change.)

Attachments:
        MCPackage-snapshot.st  1.4 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 5095 by renggli: Monticello snapshotting does lots of  
unnecessary screen updates
http://code.google.com/p/pharo/issues/detail?id=5095

Before it showed with an indication, but a static one. Now it shows up with  
one that changes for each item: too fast to be useful, but slowing down the  
progress significiantly.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #11 on issue 5095 by [hidden email]: Monticello snapshotting  
does lots of unnecessary screen updates
http://code.google.com/p/pharo/issues/detail?id=5095

Yes I saw

Now in 14257.
I will try to have a look because even I like that I really do not like  
this feedback. I imagine that we already entered a bug related to that  
issue but cannot find it....


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker