Issue 5109 in pharo: Gofer >> #url:username:password: doesn't support file-based urls

Status: Accepted
Owner: [hidden email]

New issue 5109 by [hidden email]: Gofer >> #url:username:password:  
doesn't support file-based urls
http://code.google.com/p/pharo/issues/detail?id=5109

Something like

Gofer new
     url: '/foo/bar/package-cache'
     package: 'myPackage'
     version: 'myVersion.40'
     load

will fail since Gofer >> #url:username:password: internally creates an  
MCHttpRepository instead of a MCCacheRepository repository.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #1 on issue 5109 by [hidden email]: Gofer >>  
#url:username:password: doesn't support file-based urls
http://code.google.com/p/pharo/issues/detail?id=5109#c1

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ReviewNeeded

Comment #2 on issue 5109 by [hidden email]: Gofer >>  
#url:username:password: doesn't support file-based urls
http://code.google.com/p/pharo/issues/detail?id=5109#c2

This Issue has been marked for review by Ulysse the Monkey:

Monkey went bananas:
--------------------
Error while loading SLICE-Issue-5109-gofer-url-madness-CamilloBruni.1 from  
http://ss3.gemstone.com/ss/PharoInbox:
         
FileDoesNotExistException: '/Users/cami-data/education/phd/projects/pharo/Monkey5109/package-cache/Gofer-Core-CamilloBruni.141.mcz'
  1: MultiByteFileStream class(StandardFileStream class)>>readOnlyFileNamed:
  2: FileStream class>>readOnlyFileNamed:
  3: MCCacheRepository(MCDirectoryRepository)>>readStreamForFileNamed:do:
  4: MCCacheRepository(MCFileBasedRepository)>>versionReaderForFileNamed:do:
  5: MCCacheRepository(MCFileBasedRepository)>>loadVersionFromFileNamed:
  6: MCCacheRepository(MCFileBasedRepository)>>goferVersionFrom:
  7: GoferResolvedReference>>version
  8: GoferLoad>>addResolved:
  9: [:dependency | self
                        addResolved: (GoferResolvedReference name: dependency versionInfo name  
repository: aResolvedReference repository)] in GoferLoad>>addResolved:
10: Array(SequenceableCollection)>>do:
        ...
----------------------------------------------------------
Loaded Source: SLICE-Issue-5109-gofer-url-madness-CamilloBruni.1 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-1.4-14261-a on StackInterpreter  
VMMaker-oscog-EstebanLorenzano.109 uuid:  
d5000300-0cf5-581f-1100-0000b8f4581f Aug  8 2011, nil, nil


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #3 on issue 5109 by [hidden email]: Gofer >>  
#url:username:password: doesn't support file-based urls
http://code.google.com/p/pharo/issues/detail?id=5109#c3

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.4

Comment #4 on issue 5109 by [hidden email]: Gofer >>  
#url:username:password: doesn't support file-based urls
http://code.google.com/p/pharo/issues/detail?id=5109

should I integrate it?
Because it seems ok.
No?

SLICE-Issue-5109-gofer-url-madness-CamilloBruni.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5109 by [hidden email]: Gofer >>  
#url:username:password: doesn't support file-based urls
http://code.google.com/p/pharo/issues/detail?id=5109

Camillo had a use case where url: received an absolute path which refered  
to the local package cache. That resulted in the wrong kind of  
MC...Repository.

This fixes that problem by relying on Url for the parsing.

We did make a couple of changes to Url and its subclasses, like introduce a  
HttpsUrl class, and made GenericUrl the default (which returns nil as  
scheme).

So, yes, I think this can be integrated.

Sven



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 5109 by [hidden email]: Gofer >>  
#url:username:password: doesn't support file-based urls
http://code.google.com/p/pharo/issues/detail?id=5109

in 14275


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 5109 by [hidden email]: Gofer >>  
#url:username:password: doesn't support file-based urls
http://code.google.com/p/pharo/issues/detail?id=5109#c7

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #8 on issue 5109 by [hidden email]: Gofer >>  
#url:username:password: doesn't support file-based urls
http://code.google.com/p/pharo/issues/detail?id=5109

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker