Issue 5116 in pharo: Reintroduce the new MethodDictionary >> rehash since it is working

Status: FixReviewNeeded
Owner: marianopeck
CC: [hidden email],  [hidden email]
Labels: Milestone-1.4

New issue 5116 by marianopeck: Reintroduce the new MethodDictionary >>  
rehash  since it is working
http://code.google.com/p/pharo/issues/detail?id=5116

Hi Marcus. Previously you removed the new version of MethodDictionary >>  
rehash because you say that ScriptLoader new cleanUpForRelease was  
crashing. But now, it is the other way arround, with the current version it  
does not work and with the new it does.

Take OUR latest Cocoa Mac VM:  
https://ci.lille.inria.fr/pharo/view/VM/job/Cog-Mac-Cocoa-blessed/

If you evaluate ScriptLoader new cleanUpForRelease, once you finish, if you  
try to ckick on the World and get the menu you get instead the fallback  
menu. If you then evaluate "" then you get the emerceny windows.

If now I put the new version in MethodDictionary >> rehash, I can execute  
ScriptLoader new cleanUpForRelease and there is no problem at all. I can  
even open the World menu without problems.

So...can we integrate it back?   It is:

MethodDictionary >> rehash

        | newInstance |
        newInstance := self species newForCapacity: self basicSize.
        1 to: self basicSize do: [ :index |
                (self basicAt: index) ifNotNil: [ :key |
                        newInstance at: key put: (array at: index) ] ].
        self copyFrom: newInstance


Tell me if you want that I create a new slice.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 5116 by marianopeck: Reintroduce the new  
MethodDictionary >> rehash  since it is working
http://code.google.com/p/pharo/issues/detail?id=5116

grrrrrr I don't know why I retried everything again and even with the new  
version I get the SYmbol DNU run:with:in:.

Greate. Now none of the 2 work.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 5116 by marianopeck: Reintroduce the new  
MethodDictionary >> rehash  since it is working
http://code.google.com/p/pharo/issues/detail?id=5116

Well...the good news is that even if I remove the invocation to  
#rehashAllInstances I have the same problem. So it has nothing to do with  
the rehash and this is safe to integrate. For the issue of the  
cleanUpForRelease, we have issue 5005


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 5116 by marianopeck: Reintroduce the new  
MethodDictionary >> rehash  since it is working
http://code.google.com/p/pharo/issues/detail?id=5116

Stef, now that we discover the problem (see issue 5005) we should integrat  
this. Do you need a slice or it is enoguh with

MethodDictionary >> rehash

        | newInstance |
        newInstance := self species newForCapacity: self basicSize.
        1 to: self basicSize do: [ :index |
                (self basicAt: index) ifNotNil: [ :key |
                        newInstance at: key put: (array at: index) ] ].
        self copyFrom: newInstance



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #4 on issue 5116 by marianopeck: Reintroduce the new  
MethodDictionary >> rehash  since it is working
http://code.google.com/p/pharo/issues/detail?id=5116

Ok, I have created a slice in inbox.

Name:  
SLICE-Issue-5116-Reintroduce-the-new-MethodDictionary--rehash-since-it-is-working-MarianoMartinezPeck.1
Author: MarianoMartinezPeck
Time: 18 January 2012, 6:20:43 pm
UUID: 78a2b964-df91-4330-a568-f30dbae38d28
Ancestors:
Dependencies: Kernel-MarianoMartinezPeck.995

Fix to issue 5116


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 5116 by [hidden email]: Reintroduce the new  
MethodDictionary >> rehash  since it is working
http://code.google.com/p/pharo/issues/detail?id=5116

But I imagine that I should integrate first 5005? no?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #6 on issue 5116 by marianopeck: Reintroduce the new  
MethodDictionary >> rehash  since it is working
http://code.google.com/p/pharo/issues/detail?id=5116

No. I think it doesn't matter, because 5005 is related to the  
compactWithoutBecome I think, and not to #rehash.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #7 on issue 5116 by [hidden email]: Reintroduce the new  
MethodDictionary >> rehash  since it is working
http://code.google.com/p/pharo/issues/detail?id=5116

in 14288


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker